Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions roborock/data/b01_q10/b01_q10_code_mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class YXDeviceState(RoborockModeEnum):
REMOTEING_STATE = "remote_control", 7
CHARGING_STATE = "charging", 8
PAUSE_STATE = "paused", 10
FAULT_STATE = "fault", 12
FAULT_STATE = "error", 12
UPGRADE_STATE = "updating", 14
DUSTING = "dusting", 22
CREATING_MAP_STATE = "creating_map", 29
Expand All @@ -187,27 +187,27 @@ class YXDeviceState(RoborockModeEnum):
class YXBackType(RoborockModeEnum):
UNKNOWN = "unknown", -1
IDLE = "idle", 0
BACK_DUSTING = "backdusting", 4
BACK_CHARGING = "backcharging", 5
BACK_DUSTING = "back_dusting", 4
BACK_CHARGING = "back_charging", 5


class YXDeviceWorkMode(RoborockModeEnum):
UNKNOWN = "unknown", -1
BOTH_WORK = "bothwork", 1
ONLY_SWEEP = "onlysweep", 2
ONLY_MOP = "onlymop", 3
BOTH_WORK = "vac_and_mop", 1
ONLY_SWEEP = "vacuum", 2
ONLY_MOP = "mop", 3
CUSTOMIZED = "customized", 4
SAVE_WORRY = "saveworry", 5
SWEEP_MOP = "sweepmop", 6
SAVE_WORRY = "save_worry", 5
SWEEP_MOP = "sweep_mop", 6


class YXDeviceCleanTask(RoborockModeEnum):
UNKNOWN = "unknown", -1
IDLE = "idle", 0
SMART = "smart", 1
ELECTORAL = "electoral", 2
DIVIDE_AREAS = "divideareas", 3
CREATING_MAP = "creatingmap", 4
DIVIDE_AREAS = "divide_areas", 3
CREATING_MAP = "creating_map", 4
PART = "part", 5


Expand Down
2 changes: 1 addition & 1 deletion tests/data/b01_q10/test_b01_q10_code_mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_q10_status_values_are_canonical() -> None:
YXDeviceState.REMOTEING_STATE: "remote_control",
YXDeviceState.CHARGING_STATE: "charging",
YXDeviceState.PAUSE_STATE: "paused",
YXDeviceState.FAULT_STATE: "fault",
YXDeviceState.FAULT_STATE: "error",
YXDeviceState.UPGRADE_STATE: "updating",
YXDeviceState.DUSTING: "dusting",
YXDeviceState.CREATING_MAP_STATE: "creating_map",
Expand Down
34 changes: 33 additions & 1 deletion tests/data/test_code_mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
import pytest

from roborock import HomeDataProduct, RoborockCategory
from roborock.data.b01_q10.b01_q10_code_mappings import B01_Q10_DP
from roborock.data.b01_q10.b01_q10_code_mappings import (
B01_Q10_DP,
YXBackType,
YXDeviceCleanTask,
YXDeviceState,
YXDeviceWorkMode,
)


def test_from_code() -> None:
Expand Down Expand Up @@ -89,3 +95,29 @@ def test_homedata_product_unknown_category():
product = HomeDataProduct.from_dict(data)
assert product.id == "unknown_cat_id"
assert product.category == RoborockCategory.UNKNOWN


def test_yx_device_state_fault_uses_error_value() -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these tests are super meaningful, plus we'd probably want them in the q10 directory instead of randomly split across the two directories. Please just revert.

"""Test YXDeviceState uses a cross-device-consistent error label."""
assert YXDeviceState.FAULT_STATE.value == "error"


def test_yx_back_type_values_are_readable() -> None:
"""Test YXBackType values are exposed as readable snake_case."""
assert YXBackType.BACK_DUSTING.value == "back_dusting"
assert YXBackType.BACK_CHARGING.value == "back_charging"


def test_yx_device_work_mode_values_are_readable() -> None:
"""Test YXDeviceWorkMode values align with readable cleaning labels."""
assert YXDeviceWorkMode.BOTH_WORK.value == "vac_and_mop"
assert YXDeviceWorkMode.ONLY_SWEEP.value == "vacuum"
assert YXDeviceWorkMode.ONLY_MOP.value == "mop"
assert YXDeviceWorkMode.SAVE_WORRY.value == "save_worry"
assert YXDeviceWorkMode.SWEEP_MOP.value == "sweep_mop"


def test_yx_device_clean_task_values_are_readable() -> None:
"""Test YXDeviceCleanTask values are exposed as readable snake_case."""
assert YXDeviceCleanTask.DIVIDE_AREAS.value == "divide_areas"
assert YXDeviceCleanTask.CREATING_MAP.value == "creating_map"
Loading