311 syntax#739
Merged
Merged
Conversation
Collaborator
|
Not sure how far you are atm, but +1 for the effort! |
Collaborator
|
@RobbieKiwi let us know when this is ready to review |
Contributor
Author
|
It's ready |
Collaborator
|
@RobbieKiwi I took the freedom to make two one-liner changes and adding a release note |
FabianHofmann
approved these changes
Jun 3, 2026
1 task
FBumann
added a commit
that referenced
this pull request
Jun 3, 2026
…turn Follow-ups to #739 (Python 3.11 syntax): - Add regression tests locking in the observable StrEnum behaviour of the status enums (value equality, str()/f-string rendering, isinstance(str)). This is the one user-visible change from the Enum -> StrEnum switch and was previously untested. - SolverStatus.from_termination_condition now returns `Self` instead of the quoted "SolverStatus", matching its sibling `process` and Status.from_termination_condition, which #739 converted but missed here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FBumann
added a commit
that referenced
this pull request
Jun 3, 2026
Follow-up to #739 (Python 3.11 syntax): SolverStatus.from_termination_condition now returns `Self` instead of the quoted "SolverStatus", matching its sibling `process` and Status.from_termination_condition, which #739 converted but missed here. No functional change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FabianHofmann
pushed a commit
that referenced
this pull request
Jun 3, 2026
) Follow-up to #739 (Python 3.11 syntax): SolverStatus.from_termination_condition now returns `Self` instead of the quoted "SolverStatus", matching its sibling `process` and Status.from_termination_condition, which #739 converted but missed here. No functional change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Use new Python 3.11 syntax
Checklist