chore: Return Self from SolverStatus.from_termination_condition#746
Merged
Conversation
FBumann
force-pushed
the
chore/strenum-followups
branch
from
c8eb24d to
08e0f28
Compare
FBumann
changed the title
Follow-up to #739 (Python 3.11 syntax): SolverStatus.from_termination_condition now returns `Self` instead of the quoted "SolverStatus", matching its sibling `process` and Status.from_termination_condition, which #739 converted but missed here. No functional change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FBumann
force-pushed
the
chore/strenum-followups
branch
from
08e0f28 to
3058810
Compare
FBumann
changed the title
FBumann
changed the title
FabianHofmann
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Small follow-up to #739 (Python 3.11 syntax modernization).
SolverStatus.from_termination_conditionstill returned the quoted"SolverStatus", while its siblingprocessandStatus.from_termination_conditionwere converted toSelfin #739. This makes it consistent.No functional change.
Checklist
🤖 Generated with Claude Code