Skip to content

fix: prevent Share Profile button flash before settings load #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priyanshu-byte-coder merged 1 commit into from
May 19, 2026
+10 −8
Merged

fix: prevent Share Profile button flash before settings load #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/components/DashboardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,28 @@ import SignOutButton from "@/components/SignOutButton";
import ThemeToggle from "@/components/ThemeToggle";
import UserAvatar from "@/components/UserAvatar";

interface UserSettings {
is_public: boolean;
}

export default function DashboardHeader() {
const { data: session } = useSession();
const [settings, setSettings] = useState<UserSettings | null>(null);
const [isPublic, setIsPublic] = useState<boolean | null>(null);

useEffect(() => {
if (!session) return;
if (!session) {
setIsPublic(null);
return;
}

async function loadSettings() {
try {
const res = await fetch("/api/user/settings");
if (res.ok) {
const data = await res.json();
setSettings(data);
setIsPublic(data.is_public === true);
} else {
setIsPublic(false);
}
} catch (error) {
console.error("Failed to load settings:", error);
setIsPublic(false);
}
}

Expand All @@ -46,7 +48,7 @@ export default function DashboardHeader() {
</div>

<div className="flex flex-wrap items-center gap-3">
{settings?.is_public && session?.githubLogin && (
{isPublic === true && session?.githubLogin && (
<a
href={`/u/${session.githubLogin}`}
target="_blank"
Expand Down
Loading