fix: prevent Share Profile button flash before settings load#328
Merged
Priyanshu-byte-coder merged 1 commit intoMay 19, 2026
Merged
Conversation
|
@jaygaikar-09 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
Priyanshu-byte-coder
approved these changes
May 19, 2026
Owner
Priyanshu-byte-coder
left a comment
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Clean fix. Changing to isPublic === true strict check ensures the button stays hidden until settings are confirmed loaded, not just until the first API call starts. Error/failure paths now default to false instead of leaving null indefinitely. The flash is eliminated.
Priyanshu-byte-coder
merged commit e2cbf39
into
Priyanshu-byte-coder:main
7 checks passed
Priyanshu-byte-coder
added
gssoc:approved
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where the "Share Profile" button briefly flashed on dashboard load for users with private profiles because the UI rendered before
/api/user/settingsfinished loading.Closes #194
Type of Change
Changes Made
isPublicflag:null→ loadingtrue→ public profilefalse→ private profile or fetch failure