Fix pseudocigar handling for constructing a PMO#85
Merged
Conversation
…ctions; updated unittests;
Contributor
|
I think this will need updates in the app too |
Member
Author
|
we can flag an issue there and approve here as we'll have to change this one first to make the changes in the app, won't affect the app right now as it's pulling from the set version so should be safe to change here and then we update the app with the next app version |
kathrynmurie
requested changes
Jul 21, 2026
kathrynmurie
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for properly constructing pseudocigar. Before, pseudocigar was being set as "pseudo_cigar" which isn't the name in the schema and it needs to be a pseudocigar object and not just the string itself (see issue #84 for more details)