Repository navigation
Stop reporting a missing configuration on every call - #35
Merged
Merged
Conversation
-wakeRegistration runs for every incoming call. With no valid account it went into the full -startWithError: path, which fails with CallWaveErrorNotConfigured whenever credentials have not arrived yet -- the documented flow where the push itself is what makes the host call -loginWithConfiguration:. The call survived, the log did not: every call carried an error for a supported state. The nudge is now a no-op with one informational line, and that login starts the stack on its own. In host-owned CallKit mode the same push also nudged twice, because the report goes through -prepareIncomingCallWithUUID:caller:, which already wakes the registration; the second nudge sent a second REGISTER per call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every incoming call logged an error:
-wakeRegistrationruns for each incoming call (from-handleVoIPPushPayload:completion:and from-prepareIncomingCallWithUUID:caller:). With no valid account it went into the full-startWithError:path, which fails withCallWaveErrorNotConfiguredwhile credentials have not arrived — the flow the README and-initWithConfiguration:options:provider:document, where the push itself is what makes the host fetch the account. The call was unaffected, because the host's-loginWithConfiguration:landed a moment later and started the stack itself; only the log was wrong.Changes
-wakeRegistrationtreats "no configuration yet" as a no-op with one informational line instead of a failed start.-handleVoIPPushPayload:completion:added a second nudge on top of the one-prepareIncomingCallWithUUID:caller:already performs, which meant twoREGISTERs per call.CallWavePushWakeRegistrationTests: noNo configurationline for a push before login, and exactly one nudge per push.Testing
./Scripts/run-package-tests.sh— 82 registry tests and 65 package tests, 0 failures.🤖 Generated with Claude Code