Repository navigation
feat(desktop): the assistant makes a knob for a shaft with one call - #327
Merged
Merged
Conversation
partbuddy_block gets the block knob: a part of its own with flutes, a pointer groove and a bore for a D shaft (flat over its last 7 mm), a split knurled shaft or a round shaft with an M3 set screw. It prints on its top and reports its print face to the plate view. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ManuelStaggl
added a commit
that referenced
this pull request
Nov 11, 2026
…its rounding (#333) Two joint tests of `app.spec.ts` failed now and then in CI (#327, #332). - Cause: the view's `data-shown` has two decimals, the app keeps a tenth of the unrounded value. 13.749 shows as 13.75, is kept as 13.7, and the tests rounded 13.75 to 13.8. Both now compare within 0.06, as the hinge test above them already does. - The wait for a standing value added in #332 rested on a wrong guess (a frame race) and is removed. - Driving two joints back to 0 gets 30 s instead of a poll's 5 s; on a loaded runner the second joint was still on its way. Both tests ran six times each locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: ManuelStaggl <17688572+ManuelStaggl@users.noreply.github.com> Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next block of the construction standards:
partbuddy_block {block: knob}.knob.ts: a knob as a part of its own, 25 × 16 mm by default, flutes every 7 mm (as the screw lid), chamfered plain band, pointer groove on the top.d(6 mm, flat at 4.5 mm from the Bourns PEC11R and Alps RK09 sheets, flat over the bore's last 7 mm; any other diameter needsflatas measured),knurl(plain bore the split shaft springs into),round(2.6 mm pilot hole for an M3 set screw).Not printed yet: the clearance (0.2 mm) comes from guides that disagree;
clearanceis the lever. Not built: star and clamping knobs (DIN 6336), modelled knurl teeth, a nut for the set screw.🤖 Generated with Claude Code