Repository navigation
test(desktop): compare a kept joint with what the view showed within its rounding - #333
Merged
Merged
Conversation
…its rounding The view shows two decimals and the app keeps a tenth of the value itself, so 13.749 showed as 13.75, was kept as 13.7 and the tests expected 13.8. The wait for a standing value from #332 did not cure that and is gone. Driving two joints back also gets more than 5 s. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two joint tests of
app.spec.tsfailed now and then in CI (#327, #332).data-shownhas two decimals, the app keeps a tenth of the unrounded value. 13.749 shows as 13.75, is kept as 13.7, and the tests rounded 13.75 to 13.8. Both now compare within 0.06, as the hinge test above them already does.Both tests ran six times each locally.
🤖 Generated with Claude Code