Skip to content

Fix TinyGo JSONBody[T] type-name collision #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pikann merged 2 commits into from
Aug 30, 2026
Merged

Fix TinyGo JSONBody[T] type-name collision #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a270a61
fix: give locally-scoped JSONBody[T] body types unique names
pikann Aug 30, 2026
7db500d
chore: bump patch version in plugin.json
pikann Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backend/scenarios.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ func (p *bddPlugin) createScenario(req *plugin.Request, res *plugin.Response) {
return
}

type body struct {
type createScenarioBody struct {
Title string `json:"title"`
Given string `json:"given"`
When string `json:"when"`
Then string `json:"then"`
}
b, err := plugin.JSONBody[body](req)
b, err := plugin.JSONBody[createScenarioBody](req)
if err != nil || b.Title == "" {
res.Error(400, "title is required")
return
Expand Down Expand Up @@ -157,13 +157,13 @@ func (p *bddPlugin) updateScenario(req *plugin.Request, res *plugin.Response) {
return
}

type body struct {
type updateScenarioBody struct {
Title *string `json:"title"`
Given *string `json:"given"`
When *string `json:"when"`
Then *string `json:"then"`
}
b, err := plugin.JSONBody[body](req)
b, err := plugin.JSONBody[updateScenarioBody](req)
if err != nil {
res.Error(400, "invalid request body")
return
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "com.paca.bdd",
"displayName": "BDD Scenarios",
"description": "Adds Given/When/Then BDD acceptance criteria to tasks.",
"version": "0.3.4",
"version": "0.3.5",
"minCoreVersion": "v0.13.3",
"permissions": ["db.read", "db.write", "events.subscribe"],
"backend": {
Expand Down
Loading