feat(acir): 支持同一 Table firing 的混合字段 proposal - #145
Merged
Merged
Conversation
This was referenced Sep 16, 2026
zhoubot
requested changes
Sep 16, 2026
zhoubot
left a comment
Contributor
There was a problem hiding this comment.
Merge blocker: publishPreparedBatch stores exact writes in PendingProposal::footprints, but conflictsWithPending() and conflictsWithPendingEndpoint() inspect only PendingProposal::footprint (simulator/gfsim/include/gfsim/queue_blocks.h:1836-1852,2184-2193). A later single/legacy endpoint can therefore reserve an overlapping entry/field after a batch is pending, violating fail-closed conflict and atomicity semantics. Please check both singular and vector footprints symmetrically and add batch-first/single-first overlap regressions, including replace-vs-field, disjoint controls, and queue-consumption assertions. This PR also inherits the #142 Slot activation blocker until the stack is repaired.
zhoubot
force-pushed
the
feat/issue-129-static-field-writes
branch
from
September 16, 2026 03:56
a7ae3c6 to
132f3d9
Compare
zhoubot
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
index/value/present/mode/field_maskfootprint。@ac.inlinehelper 的字段 provenance 推导。依赖关系
本 PR 堆叠在 #144 上,而 #144 又依赖 #142。合并顺序必须是:#142 → #144 → 本 PR;请勿在 #144 之前合并本 PR。
本 PR 当前有意以 #144 的 head commit
cd3d3e16(临时 upstream base reffeat/explicit-table-state)为基线,以便 review diff 只包含本次 issue #129 的改动。#142 和 #144 合并后,应把本分支 rebase 到最新main,并将本 PR base 改回main。本 PR 取代 #143,请勿单独合并 #143。 #143 的 proven frontend field-write 切片已被完整吸收,并进一步覆盖 module-local Table、普通/inline helper 等价性、同 owner 不同 schema 的多 proposal,以及 GFSim 逐条 footprint 原子批次。
pyc6 Decision / Contract 影响
验证
G0: Python ChecksG0: Agentic Python Checks证据:
docs/gates/logs/20260916-issue129-mixed-field-writes/summary.mddocs/gates/logs/20260916-issue129-mixed-field-writes/agentic_circuit_summary.jsondocs/gates/logs/20260916-issue129-mixed-field-writes/decision_status_report.json完整
check-acir仍保留docs/gates/logs/20260915-issue129-static-field-writes/summary.md已记录的 9 个无关 checkout baseline failure;本次修改和新增的 lit 测试全部通过,没有新增失败。文档
风险与兼容性
with ac.assert_disjoint(...)和动态同字段冲突 obligation 不在本次修改内;静态无法证明安全的同字段冲突继续 fail closed。关联