feat(agentic-circuit): require explicit Table state - #144
Merged
Merged
Conversation
Collaborator
Author
|
Dependency tracking: this PR depends on #142 and must not merge first. Current stack:
After #142 merges, rebase this branch onto the latest |
This was referenced Sep 15, 2026
hmljy2020
force-pushed
the
feat/explicit-table-state
branch
from
September 15, 2026 14:11
9936f5b to
cd3d3e1
Compare
This was referenced Sep 16, 2026
Contributor
|
Review disposition: the #144-only delta is architecturally clear and its explicit-Table hard break is documented and covered. It is not mergeable yet because the stack inherits the #142 Slot activation blocker. After #142 is repaired and merged, rebase/retarget this PR to main, rerun required checks, and obtain a fresh approval before merging. |
zhoubot
force-pushed
the
feat/explicit-table-state
branch
from
September 16, 2026 03:53
cd3d3e1 to
780bf5e
Compare
zhoubot
changed the base branch from
feat/ac-slot-rule-transactions
to
main
September 16, 2026 03:53
zhoubot
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ac.tableac.find(...)marker with receiver-ownedtable.find(...)andtable.view(row).find(...)Dependency
Depends on #142. Do not merge this PR before #142.
This PR is intentionally based on
feat/ac-slot-rule-transactionsat #142 head commit84146e9b. After #142 merges, this branch will be rebased onto the latestorigin/mainand the PR base will be changed tomain. The temporary upstream base ref exists only to keep this stacked PR's review diff limited to issue #136.后继 PR
#145 直接依赖本 PR;合并顺序为 #142 → 本 PR → #145。
#145 使用本 PR 的精确 head
cd3d3e16作为临时 upstream base,以保持 issue #129 的 review diff 独立。本 PR 合并并完成 rebase 后,#145 应 rebase 到最新main并将 base 改回main。#143 的前端切片已由 #145 取代,不应单独合并。pyc6 Decision / Contract Impact
ac.table[shape, Entry](init=...); ordinary Python lists remain static elaboration values.whereis required and keyword-only;keyis optional and keyword-only. First/min selection retains stable flattened-index tie breaking and lazy.valuereads.ac.table.get/propose/match/choose; module-local Tables may remain shapedac.varuntil storage selection.ACPY-VAR-002; formerac.findcalls fail withACPY-RULE-009and an executable migration direction.Validation
Evidence:
docs/gates/logs/20260915-issue136-explicit-table-state/summary.mddocs/gates/logs/20260915-issue136-explicit-table-state/agentic_circuit_summary.jsondocs/gates/logs/20260915-issue136-explicit-table-state/decision_status_report.jsonKnown repository baseline boundaries
The full G0/G1 wrapper was attempted. Existing checkout-wide failures remain in the deprecated top-level
designs/layout, process-statefunc.callfixtures, exact ACIR operation-registry counts, and local aarch64 SDK CLI/build-layout cases. None of those failing implementation/test files is changed here. The complete applicable issue #136 frontend, MLIR, GFSim, PYC C++, and Verilog evidence is green and the baseline boundaries are recorded in the evidence summary.Compatibility
This is an intentional hard break in the public Agentic Python source contract. Scalar persistent-state inference,
ac.array, static Python lists/list comprehensions, Queue collections, Decision 0248 flattened row indices, and the bounded PYC Table profile are unchanged.Closes #136