Skip to content

fix(site): resolve biome lint/format errors blocking pnpm run check #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnunamak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(site): resolve biome lint/format errors blocking pnpm run check #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/src/app/specification/[[...slug]]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export async function generateMetadata({ params }: DocsPageProps): Promise<Metad
// surface stayed crawlable and ranked, reachable from search even though
// nothing in the rail pointed at them.
const isInternalNotesPage = page.path === "README.md";
const isMaintainerDoc = MAINTAINER_DOC_SLUGS.some((slug) => page.path === `${slug}.md`);
const isMaintainerDoc = MAINTAINER_DOC_SLUGS.some((maintainerSlug) => page.path === `${maintainerSlug}.md`);
const canonicalUrl = isRootSlug ? "/specification" : page.url;

return {
Expand Down
5 changes: 1 addition & 4 deletions apps/site/src/lib/docs-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ export function getSpecNavTree(): PageTree.Root {
const byUrl = itemsByUrl(full);
return {
...full,
children: [
{ $id: "spec-rail-primary", name: "Specification", type: "separator" },
...pick(byUrl, PRIMARY_SLUGS),
],
children: [{ $id: "spec-rail-primary", name: "Specification", type: "separator" }, ...pick(byUrl, PRIMARY_SLUGS)],
};
}
5 changes: 1 addition & 4 deletions apps/site/src/lib/sitemap-entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ export interface DocPageRef {
// and their own noindex all keep out. Derived from MAINTAINER_DOC_SLUGS
// rather than repeated, so the rail and the sitemap cannot disagree about
// what is unlisted.
const NON_CANONICAL_DOC_PATHS = new Set([
"README.md",
...MAINTAINER_DOC_SLUGS.map((slug) => `${slug}.md`),
]);
const NON_CANONICAL_DOC_PATHS = new Set(["README.md", ...MAINTAINER_DOC_SLUGS.map((slug) => `${slug}.md`)]);

// SEO/GEO standard MUST #4.3: a sitemap must contain only canonical,
// indexable URLs, and `lastmod` must represent the last substantive change to
Expand Down
Loading