fix(site): resolve biome lint/format errors blocking pnpm run check - #179
Open
tnunamak wants to merge 1 commit into
Open
fix(site): resolve biome lint/format errors blocking pnpm run check#179tnunamak wants to merge 1 commit into
tnunamak wants to merge 1 commit into
Conversation
Three unrelated biome findings in apps/site had accumulated and were failing `pnpm run check`: - src/app/specification/[[...slug]]/page.tsx: the `isMaintainerDoc` check used `slug` as its `.some()` callback parameter, shadowing the outer `slug` (the route's resolved segment array) declared a few lines above in the same function. Renamed the callback parameter to `maintainerSlug`. - src/lib/docs-source.ts and src/lib/sitemap-entries.ts: both had an array literal formatted across multiple lines that biome's formatter (120-char line width in this app) wants collapsed onto a single line. Ran the formatter's suggested output as-is. No behavior change; `pnpm run check`, `pnpm test`, and `pnpm run types:check` all pass in apps/site. Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm run checkin apps/site was failing on three unrelated biome findings:src/app/specification/[[...slug]]/page.tsx:isMaintainerDoc's.some()callback usedslugas its parameter name, shadowing the outerslug(the route's resolved segment array) declared earlier in the same function. Renamed the callback parameter tomaintainerSlug.src/lib/docs-source.tsandsrc/lib/sitemap-entries.ts: both had an array literal formatted across multiple lines where biome's formatter (120-char line width in this app) wants it collapsed onto one line. Applied the formatter's own suggested output.No behavior change. Pure lint/format cleanup, one change per PR per this repo's convention.
Test plan
pnpm exec biome checkon all three touched files: 0 errorspnpm run check(apps/site): exit 0 (4 pre-existing, unrelatedsuppressions/unusedwarnings indata-source.ts/route.test.tsremain, confirmed present onmainbefore this change)pnpm test(apps/site): 202/202 passpnpm run types:check(apps/site): exit 0Assisted-by: AI