fix: preserve duplicate CSV columns - #20
Merged
haolpku merged 1 commit intoSep 20, 2026
Merged
Conversation
haolpku
requested changes
Sep 20, 2026
haolpku
left a comment
haolpku
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes because duplicate detection is case-sensitive. SQLite and several SQL backends treat identifiers case-insensitively, so a CSV header such as a,A still reaches CREATE TABLE with duplicate column names. Please track normalized/case-folded identifiers when allocating names and add regressions for a,A and collisions with generated col_N names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV headers were sanitized for SQL syntax but duplicate valid names were left unchanged, causing CREATE TABLE to fail and dict-based row construction to discard one value. This assigns deterministic unique fallback names to later duplicates, preserving every imported field. Added a SQLite import regression covering duplicate headers and both values. Validation: 6 replacement/import tests passed; no API or schema changes beyond deterministic import column naming; targets main.