Skip to content

fix: constrain profile names to one namespace - #18

Merged
haolpku merged 1 commit into
OpenDCAI:mainfrom
DevChiniwala:codex/validate-profile-paths
Sep 20, 2026
Merged

haolpku merged 1 commit into
OpenDCAI:mainfrom
DevChiniwala:codex/validate-profile-paths

Conversation

@DevChiniwala

Copy link
Copy Markdown
Contributor

Core DataConfig accepted path separators and traversal components in profile names, so derived data_dir and storage_dir could escape the intended data/profiles/ namespace. This adds the same safe profile-name contract already enforced by the MCP adapter and enables assignment validation so post-construction profile changes cannot bypass it. Regression coverage rejects traversal, separators, dot names, empty names, and invalid assignment. Validation: 14 config tests passed; no legacy code, storage schema, or API response changes. Targets main.

Copilot AI lite review requested due to automatic review settings September 17, 2026 10:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@haolpku
haolpku merged commit 4c520b8 into OpenDCAI:main Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants