fix: honor memory scope filters during recall - #16
Merged
haolpku merged 1 commit intoSep 20, 2026
Merged
Conversation
haolpku
requested changes
Sep 20, 2026
haolpku
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes because the implementation does not fully honor scope_filter. MemoryService only clears profile/session IDs; the SQLite store still includes global memories unconditionally. Therefore scope_filter=['profile'] and ['session'] can still return global items, and [] falls back to all scopes. Please carry an explicit allowed-scope set through the service/store (or filter before returning), define the empty-list behavior, and add tests for global-only, profile-only, session-only, combinations, and empty input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_recall accepts scope_filter to limit which memory scopes contribute, but the filter could be bypassed by MemoryService default-profile fallback.
When a caller requested global-only recall, the tool cleared the profile before calling the service. MemoryService.recall() then replaced the falsey profile with its default profile, returning profile-scoped evidence that the caller explicitly excluded.
Fix
No storage schema, response shape, or provider API changes.
Validation
The five skipped tests are optional claude_agent_sdk hook tests.