Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,35 @@

All notable changes to Pharabius are documented in this file.

## [3.7.0] - Unreleased

### Candidate Review and Promotion Workflow

Adds governed review of candidate findings with explicit decision recording.
Review decisions are append-only records. Candidate artifacts are NOT mutated.
Candidate acceptance is review-level only — it does NOT create accepted DebtFindings.

### Added

- **Candidate review module** (`core/connectors/candidate_review.py`) — `review_candidate()` function
- **Candidate-specific lifecycle outcomes** — CandidateAccepted, CandidateRejected, CandidateDeferred
- **Decision-to-outcome mapping** — review decisions map to candidate lifecycle states
- **Terminal decision guard** — one terminal decision per candidate (v3.7.0)
- **Candidate review summary** — pending/accepted/rejected/deferred counts
- **Status reader integration** — shows candidate review state
- **56 new tests** covering review, lifecycle, exclusion, no-mutation

### Design Rules

- CandidateAccepted ≠ Acknowledged — distinct from accepted finding states
- Candidate acceptance is review-level only, not debt-register promotion
- Regular review rejects CAND-* IDs; candidate review rejects TD-* IDs
- `needs-investigation` is not valid for candidates (candidates ARE pre-investigation)
- One terminal decision per candidate; supersession not supported in v3.7.0
- Candidate artifact NOT mutated by review decisions
- Lifecycle history is append-only
- Review decisions are append-only

## [3.6.0] - Unreleased

### Evidence-to-Finding Candidate Promotion
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ Pharabius is a mature CLI engine with an early-stage platform. Current limitatio
- _v3.4.0 adds **external evidence review**: imported and combined evidence visible in reports and status output. No finding creation._
- _v3.5.0 adds **workflow lifecycle governance**: explicit state model for findings and work packages with transition validation. No auto-promotion._
- _v3.6.0 adds **evidence-to-finding candidate promotion**: external evidence can propose reviewable candidate findings. Candidates are not accepted findings._
- _v3.7.0 adds **candidate review workflow**: governed review of candidates with explicit decisions. Acceptance is review-level only, not debt-register promotion._
- **No live ticket sync** — No Jira, Linear, or GitHub Issues integration
- **Platform frontend is prototype-grade** — 28 tests pass, build succeeds, but 5 pre-existing TypeScript errors in test mocks
- **No portfolio governance** — Multi-repo governance workflows not implemented
Expand Down
17 changes: 13 additions & 4 deletions docs/LIFECYCLE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,25 @@

Pharabius defines explicit lifecycle states for findings and work packages. Lifecycle state machines govern which transitions are allowed, ensuring state changes follow a valid path.

## Candidate Lifecycle (v3.6.0)
## Candidate Lifecycle (v3.6.0, v3.7.0)

External evidence can propose **candidate findings**. Candidates are pre-review artifacts that must be reviewed before becoming accepted findings.

```text
Candidate → Acknowledged (promote after review)
Candidate → Won't Fix (reject after review)
Candidate → Deferred (defer review)
Candidate → CandidateAccepted (review-level acceptance)
Candidate → CandidateRejected (review-level rejection)
Candidate → CandidateDeferred (review deferral)
```

CandidateAccepted ≠ Acknowledged. Accepted candidates remain candidates —
they are NOT promoted to debt-register.json.

Review decisions are:
- Append-only records in `.ai-debt/review/decisions.json`
- Recorded as lifecycle entries in `.ai-debt/lifecycle-history.json`
- One terminal decision per candidate (v3.7.0)
- `needs-investigation` is not valid for candidates

Candidates are:
- Stored in `.ai-debt/candidate-findings.json` (separate from `debt-register.json`)
- NOT counted in `total_findings`, severity, or priority summaries
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "pharabius"
version = "3.6.0"
version = "3.7.0"
description = "Repository-first technical debt intelligence platform"
readme = "README.md"
requires-python = ">=3.11"
Expand Down
Loading
Loading