Repository navigation
v3.7.0: Candidate Review and Promotion Workflow - #79
Merged
Merged
Conversation
Add governed review of candidate findings with explicit decision recording. Review decisions are append-only records. Candidate artifacts are NOT mutated. Candidate acceptance is review-level only — it does NOT create accepted findings. New module: src/pharabius/core/connectors/candidate_review.py - review_candidate(): records decision in review sidecar + lifecycle history - summarize_candidate_reviews(): pending/accepted/rejected/deferred counts - format_candidate_review_summary(): console output with 'review-level only' label Candidate-specific lifecycle outcomes (amendment 2): - CandidateAccepted: distinct from Acknowledged - CandidateRejected: distinct from Won't Fix - CandidateDeferred: distinct from Deferred - All three are terminal in v3.7.0 (no supersession yet) Decision-to-outcome mapping: - accepted → CandidateAccepted - rejected/risk-accepted/duplicate/already-fixed → CandidateRejected - deferred → CandidateDeferred - needs-investigation → INVALID for candidates Terminal decision guard (amendment 4): - One terminal decision per candidate - Second terminal decision raises CandidateReviewError - Deferred is also terminal in v3.7.0 ID space separation (amendment 3): - Candidate review rejects TD-* IDs - Regular review ignores CAND-* IDs FindingStatus enum: 8 → 11 states 56 new tests. 3,324 total (was 3,268). Amended acceptance criteria (21-27): 21. Candidate acceptance documented as review-level only 22. CandidateAccepted distinct from Acknowledged/Detected 23. Regular review path does not accept CAND-* IDs 24. Candidate review path does not accept TD-* IDs 25. One terminal decision per candidate 26. Candidate lifecycle entries use candidate-specific states 27. Candidate review summary distinguishes from finding reviews Boundaries preserved: - No auto-promotion - No DebtFinding creation - No work package generation - No ticket creation - No scanner execution - No historical artifact mutation - Candidate artifact NOT mutated by review Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
Alajmah
added a commit
that referenced
this pull request
Jun 13, 2026
Add governed review of candidate findings with explicit decision recording. Review decisions are append-only records. Candidate artifacts are NOT mutated. Candidate acceptance is review-level only — it does NOT create accepted findings. New module: src/pharabius/core/connectors/candidate_review.py - review_candidate(): records decision in review sidecar + lifecycle history - summarize_candidate_reviews(): pending/accepted/rejected/deferred counts - format_candidate_review_summary(): console output with 'review-level only' label Candidate-specific lifecycle outcomes (amendment 2): - CandidateAccepted: distinct from Acknowledged - CandidateRejected: distinct from Won't Fix - CandidateDeferred: distinct from Deferred - All three are terminal in v3.7.0 (no supersession yet) Decision-to-outcome mapping: - accepted → CandidateAccepted - rejected/risk-accepted/duplicate/already-fixed → CandidateRejected - deferred → CandidateDeferred - needs-investigation → INVALID for candidates Terminal decision guard (amendment 4): - One terminal decision per candidate - Second terminal decision raises CandidateReviewError - Deferred is also terminal in v3.7.0 ID space separation (amendment 3): - Candidate review rejects TD-* IDs - Regular review ignores CAND-* IDs FindingStatus enum: 8 → 11 states 56 new tests. 3,324 total (was 3,268). Amended acceptance criteria (21-27): 21. Candidate acceptance documented as review-level only 22. CandidateAccepted distinct from Acknowledged/Detected 23. Regular review path does not accept CAND-* IDs 24. Candidate review path does not accept TD-* IDs 25. One terminal decision per candidate 26. Candidate lifecycle entries use candidate-specific states 27. Candidate review summary distinguishes from finding reviews Boundaries preserved: - No auto-promotion - No DebtFinding creation - No work package generation - No ticket creation - No scanner execution - No historical artifact mutation - Candidate artifact NOT mutated by review Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds governed review of candidate findings with explicit decision recording. Review decisions are append-only records. Candidate artifacts are NOT mutated. Candidate acceptance is review-level only — it does NOT create accepted DebtFindings.
What's new
core/connectors/candidate_review.pyreview_candidate()functioncore/lifecycle.pystatus_reader.pyCandidate review lifecycle
CandidateAccepted ≠ Acknowledged. Accepted candidates remain candidates.
Four amendments implemented
Tests: 3,324 passed, 7 skipped (+56 new)
Boundaries preserved