Repository navigation
[20.0][MIG] account_move_tier_validation: Migration to 20.0 - #95
Open
Pani-k-folk wants to merge 21 commits into
Open
Pani-k-folk wants to merge 21 commits into
Pani-k-folk wants to merge 21 commits into
Conversation
OCA-git-bot
added
mod:account_move_tier_validation
Pani-k-folk
marked this pull request as ready for review
October 8, 2026 09:42
Pani-k-folk
force-pushed
the
20.0-mig-account_move_tier_validation
branch
3 times, most recently
from
October 9, 2026 11:45
94b9d42 to
ae2a998
Compare
|
could you please squash the administrative and bot/weblate commits? |
* 'Validation In Progress' so as to allow an easy location of the invoices for which a validation has been triggered, but it is not yet completed. * 'Validation Not Started' to locate bills that either require no validation, or the request for validation has not yet been initiated.
…lidation, rejection
…moves with tier validation Added tests for changes Updated error to be checked in tests Updated error to be checked in tests
Edit a new journal entry with lines in currency X different from company currency Y. Say you have a line of value (amount_currency) N, which is converted to Y(N) (debit/credit). Then `amount_total` is also N. Because the `readonly="not(review_ids)"` was added, `amount_total` is dirty and sent at save. Therefore, Odoo uses it and sets the debit/credit values of the lines to N (instead of Y(N), the converted value). It's as if it's ignoring the currency conversion (note that the values are correct through onchange before the save). To avoid this, exclude the field from being modified in `get_view`.
…field or invoice matching Co-authored-by: len-foss <len@lambdao.dev>
Assisted-by: Claude Opus 5.5
Pani-k-folk
force-pushed
the
20.0-mig-account_move_tier_validation
branch
from
October 19, 2026 06:03
ae2a998 to
0149450
Compare
Author
|
@BhaveshHeliconia Done, squashed the administrative and bot/Weblate commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on : #94
Changes
BaseCommonnow runs as a plain internal user in 20.0, so the test class sets_test_user_groups = None.Assisted-by: Claude Opus 5.5 (migration changes were reviewed and tested by me)