Repository navigation
Conversation
OCA-git-bot
added
series:20.0
mod:account_move_tier_validation_approver_group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #94, #95 and #111 (see test-requirements.txt). Ported from OCA/account-invoicing#2008 (18.0).
Changes compared to the 18.0 PR:
Fix the compute clearing approver_id instead of approver_group_id.
Fix the setting being linked to the individual approver option.
Fix the group tier definition taking its active state from the individual option.
Use the _check_has_approver() hook instead of a second _post() override. A bill can now be posted with a user OR a group.
The default group tier only applies when a group is set.
Add a search filter, tests and a new readme.