Repository navigation
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
OCA-git-bot
added
mod:base_tier_validation
bosd
force-pushed
the
19.0-fix-base_tier_validation-portal-access
branch
from
October 6, 2026 15:06
10c5671 to
ae15154
Compare
added 3 commits
October 7, 2026 10:23
…c users The 17.0 migration replaced the group-less access rules on tier.review and tier.definition by one rule per group, and so gave portal and public users read access to them. Tier validation has no record rule besides the multi-company one, so a portal user could read every review (reviewers, comments) and every definition of the company through RPC, not only those of their own documents. Portal pages and portal actions (view, PDF, chatter, sign) work on the document with sudo and do not need these rules.
A portal customer, or a public user with the access token, can view, discuss and sign a quotation that has reviews, while they cannot read the reviews themselves.
A portal vendor, or a public user with the access token, can view a purchase order that has reviews, while they cannot read the reviews themselves.
bosd
force-pushed
the
19.0-fix-base_tier_validation-portal-access
branch
from
October 7, 2026 08:27
ae15154 to
b27effc
Compare
Pani-k-folk
approved these changes
Oct 14, 2026
There was a problem hiding this comment.
Code LGTM. I'll apply the same changes in #94 (20.0 migration) after this PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 17.0 migration replaced the access rules without a group on
tier.reviewandtier.definitionby one rule per group, and in doing so gave portal and public users read access to both. Apart from the multi-company rule there is no record rule on them, so a portal user can read every review (reviewers, comments) and every definition of their company through RPC, not only those of their own documents.Portal pages do not need it: viewing, printing, chatting on and signing a document all work on the document with
sudo. This PR removes the four rules and adds tests:base_tier_validation: portal and public users cannot read reviews or definitions.sale_tier_validation: a portal customer, and a public user with the access token, can view, discuss and sign a quotation that has reviews.purchase_tier_validation: a portal vendor, and a public user with the access token, can view and print a purchase order that has reviews.I also ran Odoo's own portal tests for sale (
TestAccessRightsControllers,TestSalesControllers,TestSaleSignature) and invoices (TestPortalAttachment) with the tier modules installed.18.0 and 17.0 have the same rules; I can backport once this one is reviewed.