Repository navigation
Conversation
A quotation stays under validation until it is confirmed, also once all its reviews are approved. Signing it from the portal writes the signature fields, which were refused, so the customer could not sign and accept a quotation that went through tier validation. Allow the signature fields under validation. Accepting still confirms the order, so a quotation with open reviews still cannot be accepted.
OCA-git-bot
added
series:19.0
mod:sale_tier_validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quotation stays under validation until it is confirmed, also once all its reviews are approved. When the customer signs it on the portal, Odoo writes
signature,signed_byandsigned_on, which tier validation refuses, so a quotation that needed a review could not be signed and accepted at all.This allows those three fields under validation. Accepting still confirms the order, so a quotation whose reviews are still open still cannot be accepted. The test signs an approved quotation, and checks that other fields stay locked.
Found while writing the portal tests of #85; once this is merged, the exception those tests create for the signature fields can go.