Repository navigation
Conversation
…ange with depends readonly=False
…efinition values and the approver check Add _prepare_tier_approver_definition_values() and move the check done at post time into _check_has_approver(), so other modules can extend them.
OCA-git-bot
added
mod:account_move_tier_validation_approver
astirpe
marked this pull request as ready for review
October 22, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #109. Only the
[IMP]commit before[DON'T MERGE]is new.Adds two hooks, so other modules can extend this one:
_check_has_approver(): the check done when a vendor bill is posted._prepare_tier_approver_definition_values(): the values of the default"Validation with Approver field" tier definition.
There is no change in behavior.
This is needed by
account_move_tier_validation_approver_group, which lets agroup of users approve vendor bills. The commit comes from
OCA/account-invoicing#2008 (18.0), by @kevinkhao.