Repository navigation
[20.0][MIG] base_tier_validation_forward: Migration to 20.0 - #100
Open
Pani-k-folk wants to merge 43 commits into
Open
Pani-k-folk wants to merge 43 commits into
Pani-k-folk wants to merge 43 commits into
Conversation
Currently translated at 100.0% (35 of 35 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_forward/es/
… avoid errors TT33369
…ed, added base user group.
Currently translated at 100.0% (34 of 34 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation_forward/it/
Currently translated at 100.0% (35 of 35 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation_forward/it/
Currently translated at 100.0% (35 of 35 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation_forward/nl_NL/
… that it can be used in searchs. Similar to kevinkhao/server-ux@217de7c TT56391
…ield to validation_status TT56391
By ordering only by sequence, the order is not deterministic when there are forwards, because the forwards are created with the same sequence as the forwarded reviews.
… after forward How to reproduce: * Create two reviews for the same model with different sequences and `Approve by sequence` enabled. * Request validation on a record. Let the user of the first review forward the first validation. Desired result: The new (forward) review is in state 'pending', and the remaining review is in state 'waiting'. Actual result: Both the new (forward) review and the remaining review are in state 'pending'. Suggested solution: _compute_can_review has to be deferred during the fowarding process. It was called explicitely afterwards already.
Currently translated at 100.0% (35 of 35 strings) Translation: tier-validation-19.0/tier-validation-19.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/tier-validation-19-0/tier-validation-19-0-base_tier_validation_forward/nl/
Currently translated at 2.8% (1 of 35 strings) Translation: tier-validation-19.0/tier-validation-19.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/tier-validation-19-0/tier-validation-19-0-base_tier_validation_forward/fr/
The Forward button had no margin, so it touched the Reject button on the validation banner. Give it the same gap as between Validate and Reject.
Assisted-by: Claude Opus 5.5
Pani-k-folk
marked this pull request as ready for review
October 14, 2026 08:48
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #94
Changes
20.0.1.0.0.ir.model.accessis replaced byir.accessin 20.0. Convertedsecurity/ir.model.access.csvtosecurity/ir.access.csv, same xmlid and permissions (crudfor internal users on the forward wizard).iconattribute takes a Material Symbols name (Font Awesome is not loaded in the backend):fa-arrow-circle-right→arrow_circle_righton the Forward button.tier.review: 20.0 warnsis both compute and relatedforreview_type,reviewer_id,reviewer_group_id,has_commentandapprove_sequence, which fails thechecklog-odooCI step. On 19.0, Odoo already usedrelatedand ignoredcomputefor these fields, so I removed the unusedcompute=and the matching lines in_compute_definition_data. Behaviour does not change: they stay stored related fields, and forwarded reviews keep the values the wizard writes.Notes
base_tier_validation.mt_tier_validation_forwarded→base_tier_validation_forward.mt_tier_validation_forwarded). It is not included here to keep this a pure migration; it will be forward-ported once merged on 19.0.AI disclosure
Assisted-by: Claude Opus 5.5 (migration changes were reviewed and tested by me)