Repository navigation
[19.0][FIX] base_tier_validation_forward: keep comments of forwarded reviews - #103
Open
Pani-k-folk wants to merge 1 commit into
Open
Pani-k-folk wants to merge 1 commit into
Pani-k-folk wants to merge 1 commit into
Conversation
A forwarded review and the review created for the next reviewer share the same sequence. Forwarding again sent all reviews of that sequence to the comment wizard, which overwrote the comment of every earlier forwarded review with the new '>> reviewer' text. Only take the current user's pending review, as validate_tier does. Assisted-by: Claude Opus 5.5
Pani-k-folk
force-pushed
the
19.0-fix-base_tier_validation_forward-comment
branch
from
October 15, 2026 04:55
5dd6d3b to
7f45b1b
Compare
Contributor
|
Hi @kittiu, |
OCA-git-bot
added
mod:base_tier_validation_forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a forwarded review is forwarded again, the comments of the earlier forwarded reviews are overwritten.
Steps to reproduce:
forwarded, comment>> B.>> C(expected: still>> B).Fix
forward_tieronly passes the current user's pending review to the comment wizard, the same filtervalidate_tieruses.Tests
New
test_04_forward_a_forwarded_review: A → B → back to A → C, then C approves. It checks that each forwarded review keeps its own>> next reviewercomment. Fails before the fix, passes after.Notes
[19.0][FIX] base_tier_validation: comment support approve_sequence_bypass #37 changes
comment.wizard.add_commentto write on the last review only, which would hide this bug by chance (review id order). This PR fixes the cause inforward_tierand works with or without [19.0][FIX] base_tier_validation: comment support approve_sequence_bypass #37.To be forward-ported to 20.0 ([20.0][MIG] base_tier_validation_forward: Migration to 20.0 #100).
AI disclosure
Assisted-by: Claude Opus 5.5 (changes were reviewed and tested by me)