Skip to content

[19.0][MIG] fs_storage Migration 19.0#524

Closed
cyrilmanuel wants to merge 8 commits into
OCA:19.0from
cyrilmanuel:mig-fs_storage-19
Closed

[19.0][MIG] fs_storage Migration 19.0#524
cyrilmanuel wants to merge 8 commits into
OCA:19.0from
cyrilmanuel:mig-fs_storage-19

Conversation

@cyrilmanuel

@cyrilmanuel cyrilmanuel commented Oct 8, 2025

Copy link
Copy Markdown

migration standard.

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cyrilmanuel

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cyrilmanuel

cyrilmanuel commented Oct 15, 2025

Copy link
Copy Markdown
Author

@lmignon sorry i miss something according to the migration steps (deprecated and optimization). Now it's good :)

Comment thread fs_storage/__manifest__.py Outdated

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyrilmanuel The addon is still marked as not installable 😿

@cyrilmanuel cyrilmanuel force-pushed the mig-fs_storage-19 branch 2 times, most recently from f4b8017 to 32b2974 Compare October 22, 2025 05:56

@CRogos CRogos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to restart following: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

The commit history is not preserved.

@sbidoul

sbidoul commented Nov 26, 2025

Copy link
Copy Markdown
Member

Regarding commit history, the PR looks fine (19.0 was branched off 18.0, so only the migration commits appear here), but it misses a test-requirements.txt to reference the unmerged fs_storage PR.

@sbidoul

sbidoul commented Nov 26, 2025

Copy link
Copy Markdown
Member

@cyrilmanuel can you add a test-requirements.txt like this so we can see if tests pass:

odoo-addon-server_environment @ git+https://github.com/OCA/server-env@refs/pull/247/head#subdirectory=server_environment

@jcoux

jcoux commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Did few fixes on cyrilmanuel#1
Not sure all is fixed yet.
Should be integrated here by @cyrilmanuel in next days.

@lmignon

lmignon commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@cyrilmanuel see cyrilmanuel#4

@lmignon lmignon mentioned this pull request Dec 8, 2025
1 task
@lmignon

lmignon commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@cyrilmanuel I finalized your PR into into #543. Thank you for your work.

@cyrilmanuel

Copy link
Copy Markdown
Author

closed because superseed on #543

@cyrilmanuel cyrilmanuel closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants