[19.0][MIG] fs_attachment Migration 19.0

[cyrilmanuel]

depend on #524

[CRogos]

I think you need to restart following: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

The commit history is not preserved.

[sbidoul]

The PR looks fine (19.0 was branched off 18.0, so only the migration commits appear here), but it misses a test-requirements.txt to reference the unmerged fs_storage PR.

[sbidoul]

@cyrilmanuel can you add a test-requirements.txt like this so we can see if tests pass:

odoo-addon-server_environment @ git+https://github.com/OCA/server-env@refs/pull/247/head#subdirectory=server_environment
odoo-addon-fs_storage @ git+https://github.com/OCA/storage@refs/pull/524/head#subdirectory=fs_storage

[sbidoul]

There are also a few pre-commit issues that need addressing. The empty domains errors in pylint can be ignored with a # pylint: disable=... comment.

[jcoux]

Did few fixes on cyrilmanuel#2
Not sure all is fixed yet.
Should be integrated here by @cyrilmanuel in next days.

[lmignon]

@cyrilmanuel some fixes here cyrilmanuel#3

[lmignon]

@cyrilmanuel I moved forward with your great work in #544 ....