Skip to content

[20.0][IMP] openupgrade_scripts: mark ir.model.access as merged into ir.access for the purposes of upgrade_analysis #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbrunn wants to merge 1 commit into
base: 20.0
Choose a base branch
from
Open

[20.0][IMP] openupgrade_scripts: mark ir.model.access as merged into ir.access for the purposes of upgrade_analysis #6076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openupgrade_scripts/apriori.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@
# only used here for upgrade_analysis
merged_models = {
# odoo
"ir.model.access": "ir.access",

@MiquelRForgeFlow MiquelRForgeFlow Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ir.rule": "ir.access",
this too

@hbrunn hbrunn Nov 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? typically, Odoo reuses the xmlid of the ir.model.access record

@MiquelRForgeFlow MiquelRForgeFlow Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here doesn't say merging xmlids, it's about the model. The commit odoo/odoo@77c17e7 explicitly says that ir.rule is changed to ir.access. And in odoo/odoo@26cc6ac, ir.rule is removed.

@MiquelRForgeFlow MiquelRForgeFlow Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this is just to compare, to get a nice analysis. Of course, in the migration scripts, we should probably do something, an script, but not pure merging.

# OCA/...
}
Loading