Repository navigation
Conversation
for the purposes of upgrade_analysis
| # only used here for upgrade_analysis | ||
| merged_models = { | ||
| # odoo | ||
| "ir.model.access": "ir.access", |
There was a problem hiding this comment.
"ir.rule": "ir.access",
this too
There was a problem hiding this comment.
why? typically, Odoo reuses the xmlid of the ir.model.access record
There was a problem hiding this comment.
Here doesn't say merging xmlids, it's about the model. The commit odoo/odoo@77c17e7 explicitly says that ir.rule is changed to ir.access. And in odoo/odoo@26cc6ac, ir.rule is removed.
There was a problem hiding this comment.
I mean, this is just to compare, to get a nice analysis. Of course, in the migration scripts, we should probably do something, an script, but not pure merging.
|
In fact, I have the full apriori filled. Do you prefer for me toI push here, or for me to wait this is merged and then I made another PR? |
|
I'd suggest a PR as we seem to disagree what the content should be |
I don't actually merge those models in the base migration because this would cause a lot of issues and make the migration much more complex, but upgrade_analysis should treat them as equal because it creates a lot of unhelpful entries in the work files. Will also cause a bunch of modules to be marked as "No DB changes" if that's the only change