Repository navigation
fix(cstest): guard disabled RISC-V CSR comparison - #10
Merged
Merged
Conversation
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building
cstestwith RISC-V disabled fails to link because the CSR comparator still referencesgetSysRegName, whose implementation belongs to that optional backend. Guard the comparison with the existing backend definition and fail the comparison if it is reached without RISC-V support. Keep enabled RISC-V comparisons unchanged and format the modified function using LLVM conventions.Validation: reproduced the undefined symbol before the fix; the complete GCC x86-only build now succeeds with warnings kept as errors. All 76 x86 unit/negative checks pass, the x86 detail corpus passes all 444 decoded instructions, and the enabled RISC-V detail corpus passes all 375 instructions before and after. Only the test tool changes; production decoding sources are untouched.