Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/request-nvskills-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES.
# All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# NVSkills CI evaluates and signs changes under skills/. The NVIDIA skills
# catalog (github.com/NVIDIA/skills) syncs these skills from main every hour,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Question: preserve the documentation reference when publishing skills

Question: before catalog onboarding, could we make the tabular skill’s ../../docs/reference/prediction-output.md link portable? The catalog copies each skill directory, leaving this explanation-schema document behind; an isolated copy reproduces the missing target. Assuming onboarding uses that layout, an absolute repository URL or an included reference would preserve access for readers of the published skill.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #110 (a0fe6e187, on v2-candidate). The three links that left a skill now use the repository URL:

  • sdm-tabular/SKILL.md and sdm-relational/references/beyond-one-answer.md → https://github.com/NVIDIA/structured-data-models-client/blob/main/docs/reference/prediction-output.md
  • sdm-relational/references/in-process.md → .../blob/main/docs/get-started/quickstart.md

A new test, test_a_skill_links_only_to_skills, fails any relative link that leads out of a skill directory, so this can't come back. I also copied both skill directories out on their own, the way the catalog lays them out: all 29 remaining relative links resolve.

One thing to decide: I pointed at blob/main because that's where these docs will live after 2.0 and it's the form the docs already use. Until v2-candidate merges, though, main's prediction-output.md is the 1.x version: it documents gradients but not result.explanations.columns or the sdm_gradient_v1 details. Linking blob/v2-candidate would be accurate today but would break when the branch is retired. Happy to switch if you'd rather.

# and accepts only files that match the signature (skill.oms.sig) NVSkills CI
# writes into the PR. This is the catalog's request workflow, unchanged except

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Generated signing documents fail the skills inventory test

When signing adds skill-card.md or BENCHMARK.md under a skill folder, normal CI raises KeyError: the skills tests collect every Markdown file but require each filename in their table inventory. Adding a plain BENCHMARK.md reproduces this. Could we exclude the known generated documents from authored-skill checks, or validate them separately, before running the signing flow on #82?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #110 (a0fe6e187, on v2-candidate). tests/test_skills.py now leaves out the catalog's own files (CATALOG_FILES = {'skill-card.md', 'BENCHMARK.md'}) when it collects the documents it checks. They follow the catalog's template, NVSkills CI writes BENCHMARK.md itself, and no skill links to either. skill.oms.sig isn't Markdown, so nothing collected it.

To reproduce your scenario, I took the files a real signing commit added on kumo-engine (NVIDIA/kumo-engine@9680c1ac: BENCHMARK.md, the rewritten skill-card.md and skill.oms.sig), dropped them into both skill directories on #110's branch and staged them:

  • pytest tests/test_skills.py: 232 passed, 18 skipped (the live checks). No KeyError.
  • scripts/check_repo_hygiene.py all: clean, once the borrowed card names this repo (a real signing run here writes this repo's URL).
  • ruff check .: clean.

# that it is pinned to a SHA like every other action here. When the catalog
# changes the template, re-pin to its current main.
#
# A maintainer or admin comments `/nvskills-ci` on a PR to start a run. It needs
# the NVSKILLS_CI_DISPATCH_TOKEN secret. A PR that does not touch skills/ skips
# it.
name: Request NVSkills CI

on:
issue_comment:
types: [created]
pull_request:
types: [opened, reopened, synchronize, ready_for_review]
push:

jobs:
request:
if: >
github.event_name == 'pull_request' ||
(github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
startsWith(github.event.comment.body, '/nvskills-ci')) ||
(github.event_name == 'push' &&
github.actor == (vars.NVSKILLS_SIGNATURE_PUSH_ACTOR || 'nv-skills-ci[bot]') &&
startsWith(github.event.head_commit.message, vars.NVSKILLS_SIGNATURE_COMMIT_TITLE || 'Attach NVSkills validation signatures'))
permissions:
contents: read
pull-requests: read
statuses: read
uses: NVIDIA/skills/.github/workflows/team-request.yml@b707bbe61ff1026dd59a44140610f92c8eae1151 # main, 2026-11-06
secrets:
NVSKILLS_CI_DISPATCH_TOKEN: ${{ secrets.NVSKILLS_CI_DISPATCH_TOKEN }}
Loading