Repository navigation
Add the NVSkills CI request workflow #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. | ||
| # All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # NVSkills CI evaluates and signs changes under skills/. The NVIDIA skills | ||
| # catalog (github.com/NVIDIA/skills) syncs these skills from main every hour, | ||
| # and accepts only files that match the signature (skill.oms.sig) NVSkills CI | ||
| # writes into the PR. This is the catalog's request workflow, unchanged except | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Generated signing documents fail the skills inventory test When signing adds
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in #110 ( To reproduce your scenario, I took the files a real signing commit added on kumo-engine (NVIDIA/kumo-engine@9680c1ac:
|
||
| # that it is pinned to a SHA like every other action here. When the catalog | ||
| # changes the template, re-pin to its current main. | ||
| # | ||
| # A maintainer or admin comments `/nvskills-ci` on a PR to start a run. It needs | ||
| # the NVSKILLS_CI_DISPATCH_TOKEN secret. A PR that does not touch skills/ skips | ||
| # it. | ||
| name: Request NVSkills CI | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, ready_for_review] | ||
| push: | ||
|
|
||
| jobs: | ||
| request: | ||
| if: > | ||
| github.event_name == 'pull_request' || | ||
| (github.event_name == 'issue_comment' && | ||
| github.event.issue.pull_request && | ||
| startsWith(github.event.comment.body, '/nvskills-ci')) || | ||
| (github.event_name == 'push' && | ||
| github.actor == (vars.NVSKILLS_SIGNATURE_PUSH_ACTOR || 'nv-skills-ci[bot]') && | ||
| startsWith(github.event.head_commit.message, vars.NVSKILLS_SIGNATURE_COMMIT_TITLE || 'Attach NVSkills validation signatures')) | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| statuses: read | ||
| uses: NVIDIA/skills/.github/workflows/team-request.yml@b707bbe61ff1026dd59a44140610f92c8eae1151 # main, 2026-11-06 | ||
| secrets: | ||
| NVSKILLS_CI_DISPATCH_TOKEN: ${{ secrets.NVSKILLS_CI_DISPATCH_TOKEN }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Question: preserve the documentation reference when publishing skills
Question: before catalog onboarding, could we make the tabular skill’s
../../docs/reference/prediction-output.mdlink portable? The catalog copies each skill directory, leaving this explanation-schema document behind; an isolated copy reproduces the missing target. Assuming onboarding uses that layout, an absolute repository URL or an included reference would preserve access for readers of the published skill.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #110 (
a0fe6e187, onv2-candidate). The three links that left a skill now use the repository URL:sdm-tabular/SKILL.mdandsdm-relational/references/beyond-one-answer.md→https://github.com/NVIDIA/structured-data-models-client/blob/main/docs/reference/prediction-output.mdsdm-relational/references/in-process.md→.../blob/main/docs/get-started/quickstart.mdA new test,
test_a_skill_links_only_to_skills, fails any relative link that leads out of a skill directory, so this can't come back. I also copied both skill directories out on their own, the way the catalog lays them out: all 29 remaining relative links resolve.One thing to decide: I pointed at
blob/mainbecause that's where these docs will live after 2.0 and it's the form the docs already use. Untilv2-candidatemerges, though,main'sprediction-output.mdis the 1.x version: it documents gradients but notresult.explanations.columnsor thesdm_gradient_v1details. Linkingblob/v2-candidatewould be accurate today but would break when the branch is retired. Happy to switch if you'd rather.