Skip to content

Add the NVSkills CI request workflow - #109

Open
kumo-isaac wants to merge 1 commit into
mainfrom
igutierrez/nvskills-request-workflow
Open

kumo-isaac wants to merge 1 commit into
mainfrom
igutierrez/nvskills-request-workflow

Conversation

@kumo-isaac

Copy link
Copy Markdown
Collaborator

Problem

/nvskills-ci starts an NVSkills CI signing run. It is an issue_comment trigger, and GitHub runs issue_comment workflows only from the copy on main, never from a pull request's.

#82 adds this workflow together with the skill files it is meant to sign. Until the workflow is on main, /nvskills-ci on #82 starts nothing, and the skills cannot be signed or published to the NVIDIA skills catalog. Kumo Engine split it out the same way in NVIDIA/kumo-engine#371.

Change

Adds .github/workflows/request-nvskills-ci.yml and nothing else. It is byte-identical to the copy on #82, so #82 merges cleanly over it.

  • It is the catalog's request workflow. The only changes are a header comment and a pin of team-request.yml to b707bbe instead of @main, the same pin Kumo Engine uses. team-request.yml is unchanged between that commit and the catalog's current main.
  • CODEOWNERS (*) already requires owner review for workflow changes, which NVSkills CI onboarding asks for.
  • On a pull request that changes nothing under skills/ the workflow skips. On one that does, its require-nvskills-ci job fails until someone comments /nvskills-ci and the run reports back. Prepare the agent skills for the NVIDIA skills catalog #82 shows that today.

What it needs before it does anything

  • An admin installs the nv-skills-ci GitHub App on this repository and saves the repository secret NVSKILLS_CI_DISPATCH_TOKEN.
  • NVCARPS adds this repository to config/onboarded-repositories.json in NVIDIA/nvskills-ci, as they did for Kumo Engine in NVIDIA/nvskills-ci#112.
  • The person who comments /nvskills-ci needs maintain or admin on this repository.

Validation

🤖 Generated with Claude Code

/nvskills-ci is an issue_comment trigger, so GitHub runs it from the
copy of this workflow on main, never from a pull request's. #82 adds
this file beside the skill changes it is meant to sign, so the first
/nvskills-ci on #82 cannot start until the file is on main. This lands
it on its own, byte for byte as #82 carries it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: igutierrez <igutierrez@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Adds a GitHub Actions workflow that requests NVSkills CI for pull-request events, qualifying /nvskills-ci comments, and matching signature pushes. The job calls a pinned reusable workflow with read permissions and a dispatch token.

Changes: NVSkills CI request

Layer / File(s) Summary
Configure NVSkills CI triggers and request
.github/workflows/request-nvskills-ci.yml
Defines pull-request, issue-comment, and push triggers. The job applies conditions to each event type and calls a pinned reusable workflow with read permissions and NVSKILLS_CI_DISPATCH_TOKEN.

Possibly related PRs

Change: Other

Merge Risk: Minimal · up to 94976

This adds the NVSkills CI request workflow so /nvskills-ci can be used on pull requests. No concrete defects were found. Setup (the GitHub App, dispatch token, and onboarding) must be completed before it will function.

Architecture risk: Low · up to 94976

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/request-nvskills-ci.yml: Adds copyright and license notices and comments describing the workflow, its catalog synchronization context, the /nvskills-ci trigger, and the dispatch-token requirement.
  • observed — Modified behavior in .github/workflows/request-nvskills-ci.yml: Defines the workflow name and triggers it on created issue comments, specified pull-request events, and pushes.
  • observed — Modified behavior in .github/workflows/request-nvskills-ci.yml: Adds a request job with conditions for pull-request events, qualifying PR comments, or pushes matching the configured actor and commit-message prefixes (with defaults when variables are unset). The job delegates to a reusable workflow pinned to a SHA, grants read permissions for contents, pull requests, and statuses, and passes the dispatch-token secret.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adding the NVSkills CI request workflow file. It matches the changeset, which adds only .github/workflows/request-nvskills-ci.yml, so the check passes.
Description check Passed The description explains the problem, the change (one workflow file byte-identical to PR #82's copy, with a pin of team-request.yml to b707bbe), the prerequisites, and validation steps. It is directly…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the change (one workflow file byte-identical to PR #82's copy, with a pin of team-request.yml to b707bbe), the prerequisites, and validation steps. It is directly related to the changeset, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0f95e84 and 94976ab.

Files selected for processing: 1

  • .github/workflows/request-nvskills-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

# NVSkills CI evaluates and signs changes under skills/. The NVIDIA skills
# catalog (github.com/NVIDIA/skills) syncs these skills from main every hour,
# and accepts only files that match the signature (skill.oms.sig) NVSkills CI
# writes into the PR. This is the catalog's request workflow, unchanged except

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Generated signing documents fail the skills inventory test

When signing adds skill-card.md or BENCHMARK.md under a skill folder, normal CI raises KeyError: the skills tests collect every Markdown file but require each filename in their table inventory. Adding a plain BENCHMARK.md reproduces this. Could we exclude the known generated documents from authored-skill checks, or validate them separately, before running the signing flow on #82?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #110 (a0fe6e187, on v2-candidate). tests/test_skills.py now leaves out the catalog's own files (CATALOG_FILES = {'skill-card.md', 'BENCHMARK.md'}) when it collects the documents it checks. They follow the catalog's template, NVSkills CI writes BENCHMARK.md itself, and no skill links to either. skill.oms.sig isn't Markdown, so nothing collected it.

To reproduce your scenario, I took the files a real signing commit added on kumo-engine (NVIDIA/kumo-engine@9680c1ac: BENCHMARK.md, the rewritten skill-card.md and skill.oms.sig), dropped them into both skill directories on #110's branch and staged them:

  • pytest tests/test_skills.py: 232 passed, 18 skipped (the live checks). No KeyError.
  • scripts/check_repo_hygiene.py all: clean, once the borrowed card names this repo (a real signing run here writes this repo's URL).
  • ruff check .: clean.

# SPDX-License-Identifier: Apache-2.0

# NVSkills CI evaluates and signs changes under skills/. The NVIDIA skills
# catalog (github.com/NVIDIA/skills) syncs these skills from main every hour,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Question: preserve the documentation reference when publishing skills

Question: before catalog onboarding, could we make the tabular skill’s ../../docs/reference/prediction-output.md link portable? The catalog copies each skill directory, leaving this explanation-schema document behind; an isolated copy reproduces the missing target. Assuming onboarding uses that layout, an absolute repository URL or an included reference would preserve access for readers of the published skill.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #110 (a0fe6e187, on v2-candidate). The three links that left a skill now use the repository URL:

  • sdm-tabular/SKILL.md and sdm-relational/references/beyond-one-answer.md → https://github.com/NVIDIA/structured-data-models-client/blob/main/docs/reference/prediction-output.md
  • sdm-relational/references/in-process.md → .../blob/main/docs/get-started/quickstart.md

A new test, test_a_skill_links_only_to_skills, fails any relative link that leads out of a skill directory, so this can't come back. I also copied both skill directories out on their own, the way the catalog lays them out: all 29 remaining relative links resolve.

One thing to decide: I pointed at blob/main because that's where these docs will live after 2.0 and it's the form the docs already use. Until v2-candidate merges, though, main's prediction-output.md is the 1.x version: it documents gradients but not result.explanations.columns or the sdm_gradient_v1 details. Linking blob/v2-candidate would be accurate today but would break when the branch is retired. Happy to switch if you'd rather.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants