Skip to content

Add the nSpect vulnerability allowlist - #103

Merged
Manushpm8 merged 2 commits into
v2-candidatefrom
nspect-vuln-allowlist
Nov 12, 2026
Merged

Manushpm8 merged 2 commits into
v2-candidatefrom
nspect-vuln-allowlist

Conversation

@Manushpm8

@Manushpm8 Manushpm8 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The 2.0.0 source scan reports Critical and High findings in code no release ships.
nSpect reads exceptions from a .nspect-vuln-allowlist.toml file in the repository.

Change

This adds that file at the root with 22 entries.
The format is the one nSpect's scanner library validates.

The three zip 6.0.0 findings come from a build dependency of libduckdb-sys.
Only the dev-only sdm-testkit crate reaches it.
Neither sdm-py nor sdm-jni links it on any of the five release targets.

The Netty, ZooKeeper, Jersey, Avro, ICU4J, lz4java and Log4j JSON layout findings come from spark-sql_2.13 4.0.1.
java/pom.xml declares it provided and optional.
It is never packaged or passed on. The Java library is not published.

Every entry is marked open with no PSIRT reference. Each one expires on 2027-05-12.

Two packages get a real fix instead of an exception.
Spark is declared first, so its jackson-databind 2.18.2 won at compile scope.
commons-compress brought Commons Codec 1.19.0 at compile scope.
java/pom.xml now imports the Jackson BOM at 2.22.4 and pins Commons Codec at 1.22.1.
These are the lowest fixed versions the scan names.
The BOM keeps databind, core, annotations and Spark's Scala module on one version.

Validation

cargo tree -p sdm-py and -p sdm-jni with -e normal,build show no zip on all five targets.
mvn -f java/pom.xml dependency:tree lists every allowlisted Java package as provided (optional).
The file passes the scanner library's schema check.
Its matcher clears the 21 listed findings in the current scan and keeps the jackson and Codec ones.
After the pins dependency:tree resolves Jackson 2.22.4 and Commons Codec 1.22.1 at compile scope.
SparkReadersTest passes locally on the new Jackson.
check_repo_hygiene.py all and the pre-commit hooks pass.

🤖 Generated with Claude Code

The 2.0.0 source scan reports 22 Critical and High findings in code that no
release ships. The zip crate is a build dependency of libduckdb-sys, which
only the dev-only sdm-testkit reaches. The Java findings come from
spark-sql_2.13, which java/pom.xml declares provided and optional, and the
Java library is not published.

Each entry gives the reason and the command that shows it. Each one is
marked open with no PSIRT reference and expires on 2027-05-12.

jackson-databind 2.18.2 and Apache Commons Codec 1.19.0 are left out on
purpose. Both resolve at compile scope in java/pom.xml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Spark is declared before databricks-sdk-java, so its Jackson 2.18.2 won
mediation and resolved at compile scope. commons-compress brought Commons
Codec 1.19.0 at compile scope. Both reached target/lib and the CI JAR
artifact. The scan reports BDSA-2026-16110, -16111 and -30990 against
jackson-databind 2.18.2 and BDSA-2026-39919 against Commons Codec 1.19.0.

The Jackson BOM keeps databind, core, annotations, the datatype modules
and Spark's Scala module on one version. 2.22.4 and 1.22.1 are the lowest
fixed versions the scan names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@Manushpm8
Manushpm8 merged commit bce176f into v2-candidate Nov 12, 2026
80 checks passed
@Manushpm8
Manushpm8 deleted the nspect-vuln-allowlist branch November 12, 2026 20:59
Manushpm8 added a commit that referenced this pull request Nov 12, 2026
## Problem

The 2.0.0 source scan still reports Critical and High findings.
nSpect no longer honors the allowlist from #103.
These findings have to go away by upgrading.

## Change

`duckdb` and `libduckdb-sys` go from 1.10506.0 to 1.10506.1.
It bundles the same DuckDB 1.5.6 sources.
Its build dependency moves from `zip` 6.0.0 to 9.5.1.
The four `zip` advisory ignores in `rust/deny.toml` are removed.

`java/pom.xml` pins what Spark 4.0.1 brings.
Each pin is the lowest release on Spark's own line that clears every
flagged ID.

| Package | Old | New |
|---|---|---|
| Netty (netty-bom) | 4.1.118.Final | 4.1.138.Final |
| Jersey (jersey-bom) | 3.0.16 | 3.0.17 |
| Log4j (log4j-bom) | 2.24.3 | 2.25.5 |
| ZooKeeper | 3.9.3 | 3.9.5 |
| Avro | 1.12.0 | 1.12.1 |
| ICU4J | 76.1 | 77.1 |
| lz4-java | org.lz4 1.8.0 | at.yawk.lz4 1.11.4 |
| Commons Codec | 1.22.1 | 1.23.0 |

The fixed versions come from the Black Duck records in nSpect.
Netty 4.1.138 fixes every flagged Netty ID, so Spark stays on Netty 4.1.
lz4-java moved to `at.yawk.lz4`. Spark's `org.lz4` copy is excluded and
the fork is declared provided.
Commons Codec 1.23.0 clears BDSA-2026-39919, a new High on 1.22.1.

Every allowlist entry is now fixed. The allowlist file is removed.

## Validation

`cargo update -p duckdb --precise 1.10506.1` changes only `duckdb`,
`libduckdb-sys`, `zip` and zip 9's own dependencies.
`cargo deny check` passes with the same warnings as before.
`rust_notices.py --check` passes. No shipped crate changed.
`mvn dependency:tree` resolves every package above to its new version in
all scopes.
The shipped runtime classpath differs from the base only in Commons
Codec.
`SparkReadersTest` passes on JDK 21 with a local Spark session.
`java/parity-connect-pom.xml` is a test launcher the scan does not
report.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Manush Murali <manushm@nvidia.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant