Repository navigation
Upgrade the dependencies the source scan flags - #107
Merged
Merged
Conversation
The 2.0.0 source scan reports Critical and High findings in zip and in packages Spark 4.0.1 brings. nSpect no longer honors the allowlist, so upgrade them instead. duckdb and libduckdb-sys go to 1.10506.1. It bundles the same DuckDB 1.5.6 sources and moves its build dependency from zip 6 to zip 9.5.1. The four zip advisory ignores in deny.toml go with it. java/pom.xml pins each package Spark brings at the lowest release on Spark's own line that clears the scan's IDs. Netty 4.1.138.Final, Jersey 3.0.17, Log4j 2.25.5, ZooKeeper 3.9.5, Avro 1.12.1, ICU4J 77.1. lz4-java moved to at.yawk.lz4, so Spark's org.lz4 copy is excluded and at.yawk.lz4 1.11.4 declared provided in its place. commons-codec goes to 1.23.0 for BDSA-2026-39919. Every allowlist entry is now fixed, so the allowlist is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 2.0.0 source scan still reports Critical and High findings.
nSpect no longer honors the allowlist from #103.
These findings have to go away by upgrading.
Change
duckdbandlibduckdb-sysgo from 1.10506.0 to 1.10506.1.It bundles the same DuckDB 1.5.6 sources.
Its build dependency moves from
zip6.0.0 to 9.5.1.The four
zipadvisory ignores inrust/deny.tomlare removed.java/pom.xmlpins what Spark 4.0.1 brings.Each pin is the lowest release on Spark's own line that clears every flagged ID.
The fixed versions come from the Black Duck records in nSpect.
Netty 4.1.138 fixes every flagged Netty ID, so Spark stays on Netty 4.1.
lz4-java moved to
at.yawk.lz4. Spark'sorg.lz4copy is excluded and the fork is declared provided.Commons Codec 1.23.0 clears BDSA-2026-39919, a new High on 1.22.1.
Every allowlist entry is now fixed. The allowlist file is removed.
Validation
cargo update -p duckdb --precise 1.10506.1changes onlyduckdb,libduckdb-sys,zipand zip 9's own dependencies.cargo deny checkpasses with the same warnings as before.rust_notices.py --checkpasses. No shipped crate changed.mvn dependency:treeresolves every package above to its new version in all scopes.The shipped runtime classpath differs from the base only in Commons Codec.
SparkReadersTestpasses on JDK 21 with a local Spark session.java/parity-connect-pom.xmlis a test launcher the scan does not report.🤖 Generated with Claude Code