[release-1.19] fix: Additional GIDs are dropped due to file mode mask#1752
Open
github-actions[bot] wants to merge 1 commit intorelease-1.19from
Open
[release-1.19] fix: Additional GIDs are dropped due to file mode mask#1752github-actions[bot] wants to merge 1 commit intorelease-1.19from
github-actions[bot] wants to merge 1 commit intorelease-1.19from
Conversation
The filemode returned from DeviceFromPath clears the bits that are track whether the device is a character device. This means that the check that ensures that the mode includes the character device bits always fails and no additional GIDs are detected. This change removes the check. In practice this should have no effect since we only ever detect char devices. Signed-off-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Christopher Desiniotis <cdesiniotis@nvidia.com> (cherry picked from commit 2e9a666)
Contributor
|
/ok to test 3cf726c |
cdesiniotis
approved these changes
Apr 6, 2026
Coverage Report for PR #1752Coverage increased (+0.06%) to 43.406%Diff Coverage: No coverable lines changedNo coverage regressions found.
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated backport of #1745 to
release-1.19✅ Cherry-pick completed successfully with no conflicts.
Original PR: #1745
Original Author: @elezar
Cherry-picked commits (1):
2e9a666fix: Additional GIDs are dropped due to file mode maskThis backport was automatically created by the backport bot.