fix: Additional GIDs are dropped due to file mode mask#1745
Merged
cdesiniotis merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Member
Author
|
/cherry-pick release-1.19 |
elezar
force-pushed
the
fix-additional-gids
branch
from
59a191c to
771f0e0
Compare
Coverage Report for PR #1745Coverage increased (+0.06%) to 43.406%Diff Coverage: No coverable lines changedNo coverage regressions found.
💛 - Coveralls |
elezar
added a commit
to elezar/k8s-device-plugin
that referenced
this pull request
Mar 26, 2026
This change updates the nvcdi API to 771f0e013469345c49397d78e048395978f6e2d6 to include the changes for NVIDIA/nvidia-container-toolkit#1745. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
to elezar/k8s-device-plugin
that referenced
this pull request
Mar 26, 2026
This change updates the nvcdi API to 771f0e013469345c49397d78e048395978f6e2d6 to include the changes for NVIDIA/nvidia-container-toolkit#1745. Signed-off-by: Evan Lezar <elezar@nvidia.com>
6 tasks
The filemode returned from DeviceFromPath clears the bits that are track whether the device is a character device. This means that the check that ensures that the mode includes the character device bits always fails and no additional GIDs are detected. This change removes the check. In practice this should have no effect since we only ever detect char devices. Signed-off-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
fix-additional-gids
branch
from
771f0e0 to
2e9a666
Compare
cdesiniotis
approved these changes
Apr 6, 2026
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
One non-blocking question, otherwise this lgtm.
I did add one unit test to your commit, which fails without the change.
| if path == "" { | ||
| path = d.Path | ||
| } | ||
| dn, err := devices.DeviceFromPath(path, "rwm") |
Contributor
There was a problem hiding this comment.
Question -- I do see that dn returned here does have a member Type. What if we used that to set the corresponding Type field in the CDI spec for this device? Or is there a reason why do do not set the Type field?
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filemode returned from DeviceFromPath clears the bits that are track whether the device is a character device. This means that the check that ensures that the mode includes the character device bits always fails and no additional GIDs are detected.
This change removes the check. In practice this should have no effect since we only ever detect char devices.