Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Pre-merge checks:
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Change Map Design Review | ## Summary I could not read the PR conversation comment that holds the Change map, so I could not assess its design. ## Evidence gathered - The check requires the PR conversation comment that starts w… | Provide the full body of the PR conversation comment that begins with <!-- kumo-pr-change-map --> (the comment linked as #issuecomment-7002011813). Then re-run this check. The review will test the Change map against the repository code … |
|
| Pr Size | The check fails only if the PR changes more than 40 files. The provider file count for PR #409 is not available in the supplied context, and the base branch is not in the local clone. Evidence gathere… |
Confirm the PR file count in the provider (GitHub "Files changed" tab for #409, compared with base dm-batch-prediction-xai). Fetch the base branch tip and run git diff --name-only <base-tip> <head> to count files. If the… |

Passed checks: 1 passed
-
Check name Status Explanation Public Resource Access PR #409 (author devanj08, base dm-batch-prediction-xai, head feat/training-xai-widget) was checked at commit 0cde40b against its parent 7640f27. The added lines in the repository d… Full details: Public Resource Access
-
Explanation
PR #409 (author devanj08, base dm-batch-prediction-xai, head feat/training-xai-widget) was checked at commit 0cde40b against its parent 7640f27. The added lines in the repository diff contain no added URL, git, package-index, CDN, or repository source location that a user must access to build, test, use, or contribute to the changed code: - The only
httpstrings are SVG namespace identifiers (xmlns="http://www.w3.org/2000/svg"in the Python SVG generators, andconst NS = 'http://www.w3.org/2000/svg'in the frontend JavaScript). These are XML namespace identifiers, not fetched resources, so they are excluded. -packages/kumo-engine/test/widget_exports.cjsaddsrequire('playwright')and documentsNODE_PATH=<directory-containing-playwright>. This names a package and uses a placeholder path. It adds no package source URL. -packages/kumo-engine/test/widget_validation.mdandexplainability.mdadd no links. Thepyproject.tomlchange adds only a package-data entry. - Nopip install,npm install, CDN,unpkg,jsdelivr, oresm.shreference was added. The PR description links to a GitHub blob forwidget_validation.mdat commit 0cde40b and to a PR comment. Those links are outside the repository diff. The same validation content is in the repository filepackages/kumo-engine/test/widget_validation.md, which is added by this PR. Anonymous access to those GitHub links was not tested, so they are not counted as changed-code references for this check. No added external resource reference was found that fails or cannot be tested reliably.
-
Full details: Change Map Design Review
-
Explanation
Summary I could not read the PR conversation comment that holds the Change map, so I could not assess its design. ## Evidence gathered - The check requires the PR conversation comment that starts with
<!-- kumo-pr-change-map -->. No tool in this run fetches PR comments. The description links the comment (#issuecomment-7002011813), but that link cannot be opened here. - A search of the checked-out repository forkumo-pr-change-mapfound onlydocs/development/review.md, which describes the convention. No copy of the comment exists in the repository. - The checkout is at commit0cde40b5, the PR head, withwidget_validation.mdpresent. This file holds validation results only. It does not contain the Change map. - The primary PR record matches the metadata: NVIDIA/kumo-engine#409, basedm-batch-prediction-xai, headfeat/training-xai-widget, authordevanj08. - No CodeRabbit review threads were supplied, so no review finding bears on the Change map. ## Why the verdict is INCONCLUSIVE The Change map is the only input the check evaluates. Without its text, I cannot test whether each change is necessary, whether it fits the right layer, or whether it has the observed failure, inspected behavior, smallest sufficient change, focused verification, and stopping condition. Missing evidence cannot establish PASS. The check does not define a FAIL condition for an unavailable comment, so FAIL is also not supported.Resolution
Provide the full body of the PR conversation comment that begins with
<!-- kumo-pr-change-map -->(the comment linked as#issuecomment-7002011813). Then re-run this check. The review will test the Change map against the repository code at commit 0cde40b. It will check the observed failure or release requirement, the inspected existing behavior, the proposed change set, the verification, and the stopping condition. It will also check the behavior the table omits.
Full details: Pr Size
-
Explanation
The check fails only if the PR changes more than 40 files. The provider file count for PR
#409is not available in the supplied context, and the base branch is not in the local clone. Evidence gathered: - The local HEAD is 0cde40b, "Add training diagnostics and explainability widget". It matches the PR title and touches the_explainabilitywidget files. - Parent-to-head diff of 0cde40b touches 32 files (git diff --name-only HEAD^ HEAD). - The base branchdm-batch-prediction-xaiis not present locally. Its tip is unknown. - Seven earlier commits on the local branch (68892c8 through 7640f27) are prediction-explanation work. The PR description says the stack is based on the batch-XAI API in#289, so these commits may belong to the base or to the PR. - The PR file count depends on the base tip. Counted against candidate base tips: - 7640f27: 32 files (PASS) - 5b5e466: 34 files (PASS) - 8444357: 34 files (PASS) - 1c5711a: 39 files (PASS) - 68892c8: 41 files (FAIL) - 23df659: 41 files (FAIL) - ea49aa2: 43 files (FAIL) - 0ef29e7: 48 files (FAIL) - The head commit alone is 32 files. Whether the PR also includes the earlier prediction-explanation commits decides the result. Required evidence (the exact changed-file count against the real base) remains unavailable. Missing evidence cannot establish PASS. No code defect is asserted.Resolution
Confirm the PR file count in the provider (GitHub "Files changed" tab for #409, compared with base dm-batch-prediction-xai). Fetch the base branch tip and run
git diff --name-only <base-tip> <head>to count files. If the count is 40 or fewer, the check passes. If the count exceeds 40, the check fails. In that case, split the PR into reviewable units, for example by separating the batch-XAI prerequisites from the training diagnostics widget.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Change mapRequested feature: retained training diagnostics with offline exports.
|
Summary
Display retained training diagnostics and explanations with
training_result.visualize().The widget includes evaluation charts, train/validation epoch history, column importance and sampled entity subgraphs.
It supports PDF printing of every chart view on the active tab, offline interactive HTML export and a static saved-notebook snapshot.
What Happens and Why
The existing Python API exposes retained artifacts and individual plots, but has no combined interactive diagnostic view.
This view reads the saved model and explanation outputs without starting training or inference.
Missing artifacts produce bounded views with explicit coverage rather than fabricated results.
The Fix
Reuse the shared notebook widget transport and typed subgraph readers, and add task-specific diagnostic adapters with a self-contained SVG frontend.
Keep binary cutoff controls separate from class-labeled tasks and bound graph height and initial exploration depth.
Preserve the existing UI data rules, with documented safe heatmap alignment/count handling and explicit missing/equal sensitivity scores.
Blast Radius
This is a read-only display API; training and prediction execution are unchanged.
This stack is based on the batch-XAI API in #289; retarget to main after its prerequisites merge.
Verification
The validation report records passing artifact tests and Chromium, Firefox and WebKit checks of plotted PDF content and offline HTML state using retained data.
Native notebook print dialogs and the full host/OS matrix were not validated by these local checks.
Change map.