Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Pre-merge checks:
|
| Check name | Status | Explanation |
|---|---|---|
| Pr Size | The PR #410 (NVIDIA/kumo-engine, head feat/batch-xai-widget at af77350, base feat/training-xai-widget) changes 13 files. The count is below the threshold of 40, so the PR size check passes. Evide… |
|
| Public Resource Access | The PR head is af77350, and its parent is 0cde40b, the training widget commit. I diffed the two revisions across 13 files (628 insertions, 76 deletions). The added lines contain no URL, git, package… |
Full details: Pr Size
-
Explanation
The PR
#410(NVIDIA/kumo-engine, headfeat/batch-xai-widgetat af77350, basefeat/training-xai-widget) changes 13 files. The count is below the threshold of 40, so the PR size check passes. Evidence: - The base branchfeat/training-xai-widgetis not present in the local checkout. The local history places commit 0cde40b ("Add training diagnostics and explainability widget") directly before head commit af77350 ("Display retained batch prediction explanations in notebooks"). This matches the PR description, which says the PR stacks on the training widget PR#409. -git diff --name-status -M HEAD~1 HEADlists 13 files.git diff --shortstat HEAD~1 HEADreports 13 files changed, 628 insertions, 76 deletions. Files includeexplainability.md,_explainability/_prediction.py(added),_columns.py,_snapshot.py,_subgraphs.py, static JS and CSS,explain/results.py,trainer/trainer.py, and test and validation files. - Caveat: the base tip is inferred from local history, not read from the provider. If the remote base has later commits, the GitHub file count could differ. Diffing against the full main line (main...HEAD) gives 1633 files, but that reflects the stacked prerequisite history, not this PR's changes against its target branch. Line counts were ignored, as the check requires.
Full details: Public Resource Access
-
Explanation
The PR head is af77350, and its parent is 0cde40b, the training widget commit. I diffed the two revisions across 13 files (628 insertions, 76 deletions). The added lines contain no URL, git, package-registry, CDN, or container reference. I searched for
://,http,www., CDN hosts,<script src>/<link href>, JS imports, Python URL or download calls, and package install commands. The only hits were: -http://www.w3.org/2000/svgSVG namespace strings in_snapshot.pyandcharts.js. These already existed on the base and are not added or modified lines. The SVG namespace is an identifier, not a fetched resource. - Local file URLs inwidget_exports.cjs(pathToFileURL). These are local test fixtures. - Documentation examples, including/path/to/prediction/runandNODE_PATH=<directory-containing-playwright>. These are illustrative placeholders. The PR description links to PR#409, a commit blob, and a PR comment. These links are in the description, not in the changed repository content. They are not required to build, test, or use the changed code, so they fall outside this check's scope. No added external resource reference required public-access verification.
Full details: Change Map Design Review
-
Explanation
The change map is the PR comment with marker
<!-- kumo-pr-change-map -->(id 7002013964, author devanj08). I fetched its full body and checked its 13 rows against the diff0cde40b5..af77350f. The file list matches the diff. Most rows are accurate. These claims hold in code: batch cohorts are target-free (_columns.pyhas_targets,group_view), graph samples use the producer allowlist (results.pysamples()/sample()viacollector_card(..., explanations)), batch sidecars are skipped (output = {}), the single-tab layout is limited tokind == 'prediction'(shell.jsmount), andvisualize()runs no generation. The check fails on omitted material behavior: 1. Omitted removal of the group cap._columns.py:193setslimit = MAX_GROUPS if run is not None else len(entry['cohorts']).MAX_GROUPS = 10(_columns.py:27) no longer applies to batch cohort charts. Thenames,pops,pred, andactualslices all uselimit. The change map row for_columns.pysays only "Allow cohort charts without observed targets." It does not state this behavior change, its rationale, or its bound. No test intest_prediction_explanations.pycovers more than 10 cohorts. Whether the producer bounds the cohort count was not established. This is a proven omission in the table. The rendering risk is an uncertain design question. 2. Omitted shared-path changes. The_subgraphs.pyrow does not mention the new branch incollector_card. Whentask_typeis empty, the function now inferstask_typefrom the first stored sample and setsmodel_typefrom it. This branch sits in a shared function._columns.pyalso changes the share calculation for all callers (if total_score else 0) and reformats thegroup_viewdict literal. The table describes none of these. 3. No stopping condition. The comment states a feature request and the reuse of existing readers. It does not state a stopping condition or scope boundary. The check requires one in the same comment. 4. Requirement source. "Requested feature" names no linked issue or requirement. The map gives no source for the request. Uncertain design question (not a proven defect): batch mode usesrun: Optional[Run]as a sentinel in shared functions (group_view,groups,collector_card). Those functions now branch in many places. A separate adapter may keep the training path simpler. The author should justify this choice. Verification claims inwidget_validation.md(224 tests, browser runs, fingerprints) were not re-run. They are outside the change map.Resolution
Correct the change map and the design as follows. - For
_columns.py(group_view,groups): state that batch cohort charts drop theMAX_GROUPS = 10cap. Give the reason and the expected cohort bound. Either restore a bound for batch mode (for example, keepMAX_GROUPSwhenrun is None) or justify the unbounded render. Add a test with more than 10 cohorts. - For_columns.py: list the shared-path changes. These are the zero-total guard inshareand the training-visible reformatting of thegroupsdict. Keep the reformatting out of the behavior description or revert it. - For_subgraphs.py(collector_card): add a row for the task and model inference whentask_typeis empty. Confirm that the training path never reaches it, or add a test for it. - Add a stopping condition to the change map. For example: the batch widget is complete when the listed artifact, status, and browser checks pass. Name the linked request or issue that requires the feature. - Keep thewidget_exports.cjsbatch case in a separate optional section, as the check requires. - Decide whether a separate batch adapter is simpler than therun: Optional[Run]sentinel in shared functions. Record the decision and its reason.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Change mapRequested feature: display retained batch XAI using the shared widget.
|
Summary
Display saved batch-prediction explanations with
prediction.visualize()orPredictionExplanations.load(path).visualize().Reuse the training widget renderer for cohort charts, sampled subgraphs and offline exports.
Identify the batch, model, snapshot, task and recorded row count in the header.
What Happens and Why
The batch XAI API exposes retained cohorts and graph samples but does not provide an integrated notebook view.
Batch predictions have no observed targets, so their widget must omit training diagnostics, outcome comparisons and target-derived error labels.
The Fix
Add a thin adapter over the validated prediction manifest and typed readers, honoring completed-producer allowlists and independent failed/disabled/unsupported states.
Extend the shared card and snapshot rendering only where batch data lacks outcomes or requires a single-tab layout.
Opening the widget reads saved artifacts and never reruns prediction or explanation generation.
Blast Radius
This PR stacks on the training widget PR #409 and the batch XAI API in #289; merge those prerequisites first.
It changes only display adapters and entrypoints, with no changes to prediction generation or its output schema.
Verification
The batch validation report records passing artifact/status tests and Chromium, Firefox and WebKit checks of the batch print document alongside shared training export tests.
Native notebook print/download dialogs and the full host/OS matrix were not validated by these local checks.
Change map.