Skip to content

Enable qualified native Windows CPU wheel publication - #402

Draft
danielmawhirter wants to merge 1 commit into
dm-windows-native-qualificationfrom
dm-windows-native-publication
Draft

danielmawhirter wants to merge 1 commit into
dm-windows-native-qualificationfrom
dm-windows-native-publication

Conversation

@danielmawhirter

@danielmawhirter danielmawhirter commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Native Windows wheels are built as experimental artifacts but excluded from release attachments and Kitmaker. Enable the qualified win_amd64 wheel for the 1.2 release path, with CPU training/prediction, model/snapshot restoration and CPU Faiss retrieval. Native CUDA remains deferred; WSL2 retains GPU support.

Stack: runtime #198 → qualification #401 → this publication PR. Base: dm-windows-native-qualification. Keep the existing build/dependency/GPU/platform qualification prerequisites and protected Kitmaker approval gate. Restore the caller-token correction from release PR #257 so the Portal job can resolve its protected environment secret.

Update Windows metadata and installation guidance: install kumo-engine[cpu] for CPU Faiss retrieval and select accelerator="cpu" when training/loading models. No version bump, release creation, or package publication is performed.

Validation

  • 122 focused workflow, wheel/platform metadata, installed-wheel and harness tests pass. Existing metadata tests need setuptools.command.build_py preloaded before their setuptools stub.
  • Changed Python flake8/isort, actionlint, documentation and whitespace checks pass. Root independently repeated the 21 workflow tests and actionlint.
  • Binary-only PyPI resolution of pinned faiss-cpu==1.14.3 and its dependencies succeeds for native Windows CPython 3.11, 3.12, 3.13 and 3.14; no packages installed.
  • Exact-candidate native Windows build and fresh-process CPU qualification are pending a manual rehearsal; keep this PR draft until those results are reviewed.

Change map

File-by-file rationale and verification.

Exact-candidate non-publishing rehearsal.

@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@danielmawhirter
danielmawhirter temporarily deployed to gha-kumo-workflow-tests November 18, 2026 22:22 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 2 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Change Map Design Review Warning The change map is PR comment 6993344846 (marker <!-- kumo-pr-change-map -->). I read it and checked each row against the PR head b0ff2236, diffed against dm-windows-native-qualification. The des… 1. Update the change map to list .github/workflows/kumo-glove-6b-50d-wheel.yml as a second caller of kitmaker-portal.yml. State that the optional KITMAKER_API_TOKEN now fails inside the kumo-engine-release environment, not at call v…
Passed Passed checks: 2 passed

Check name Status Explanation
Pr Size Passed PR NVIDIA/kumo-engine #402 (author danielmawhirter, base dm-windows-native-qualification, head dm-windows-native-publication) changes 8 files, which is at or below the threshold of 40. Evidence: - The…
Public Resource Access Passed The check applies only to external resource references added or modified by this PR. The PR branch has no local base ref for dm-windows-native-qualification, so I used HEAD~3..HEAD (the three PR c…
Full details: Pr Size

Explanation

PR NVIDIA/kumo-engine #402 (author danielmawhirter, base dm-windows-native-qualification, head dm-windows-native-publication) changes 8 files, which is at or below the threshold of 40. Evidence: - The base branch dm-windows-native-qualification is not present in the local checkout. Its remote-tracking ref is also absent. The count therefore relies on the local commit graph. - The checked-out HEAD is commit b0ff223 "Publish qualified native Windows CPU engine wheels". It has one parent, 71da0ed "Qualify native Windows CPU wheels in fresh processes". That commit sits on 8ca94eb "Restore native Windows training and snapshot portability", which sits on the main history. - git diff --name-only HEAD^ HEAD lists 8 files: kitmaker-portal.yml, kumo-engine-wheel.yml, README.md, releasing-kumo-engine.md, packages/kumo-engine/README.md, platform-smoke.md, pyproject.toml, and test_engine_wheel_workflow.py. This matches the PR description's scope (workflow, metadata, and installation guidance). - Diffs against the earlier stacked commits give 8 files (against 71da0ed) or 11 files (against 8ca94eb). The base is most likely one of these qualification commits, since the description states the qualification prerequisites are already in the base. - A diff against origin/main gives 55 files. That range includes the stacked runtime and qualification work and unrelated merged main history. The PR's own diff is measured against its stated base, so this figure does not apply. Every plausible base yields a count of 8 to 11, which is well under 40. The check passes. Line counts were ignored as instructed.

Full details: Public Resource Access

Explanation

The check applies only to external resource references added or modified by this PR. The PR branch has no local base ref for dm-windows-native-qualification, so I used HEAD~3..HEAD (the three PR commits on top of cce65cec) as a proxy diff. This is an approximation; the true base could differ. Added or modified external references found in that diff: 1. DGX Spark guide URL (https://github.com/NVIDIA/kumo-engine/blob/main/packages/kumo-engine/dgx-spark.md) in an added line of packages/kumo-engine/README.md. An anonymous curl -L returned HTTP 200. The file also exists in the working tree. 2. GitHub Action uses: references added in .github/workflows/kumo-engine-platform-smoke.yml: actions/checkout, actions/download-artifact, astral-sh/setup-uv, actions/upload-artifact, and aws-actions/configure-aws-credentials. Anonymous requests to the repository base URLs for actions/checkout, aws-actions/configure-aws-credentials and astral-sh/setup-uv returned HTTP 200. I did not separately test the pinned commit SHAs or the download-artifact and upload-artifact repositories. 3. Package index for the faiss-cpu install path. The PR adds the cpu extra and the install guidance, not a URL. An anonymous request to https://pypi.org/simple/faiss-cpu/ returned HTTP 200. All other added lines are repository-relative links, prose, or non-URL install commands. The uv --torch-backend=cpu flag is an option, not a changed URL string. The pyproject.toml change adds only a classifier. No added or modified reference was confirmed inaccessible. The pass rests on anonymous HTTP checks from the sandbox. A 200 on GitHub for an anonymous request indicates public read access. The check does not fail on this evidence.

Full details: Change Map Design Review

Explanation

The change map is PR comment 6993344846 (marker &lt;!-- kumo-pr-change-map --&gt;). I read it and checked each row against the PR head b0ff2236, diffed against dm-windows-native-qualification. The design is mostly sound: - The Windows rows in attach-to-release and kitmaker are gated. attach-to-release needs platform-qualification, and that job runs windows-reload on windows-2022. The job installs the exact-candidate artifact with [cpu] in four Python versions. - The [cpu] extra exists in pyproject.toml. - The platform-smoke and README changes match the code. - The validation line honestly says the exact-candidate rehearsal is pending. Substantive problems: 1. Omitted material behavior (proven). The Portal row says "Caller token contract" and describes only the kitmaker-portal.yml secret. The diff sets KITMAKER_API_TOKEN.required from true to false in a reusable workflow. A second caller, .github/workflows/kumo-glove-6b-50d-wheel.yml line 100 (kitmaker job, project: kumo-glove-6b-50d), uses the same contract and publishes with upload: true. The table does not mention it. The change also moves a missing-secret failure from call validation to inside the protected portal job. The table does not mention that either. 2. Misleading rationale (proven). The pyproject.toml row says the classifier Operating System :: Microsoft :: Windows will "Match intended native CPU distribution." The classifier applies to the whole wheel. It does not select CPU or CUDA. The CPU limit is set only by the [cpu] extra and the accelerator="cpu" guidance. 3. Unexplained mechanism (uncertain design question). The Portal row says the change lets the protected job "resolve its environment token." However, both callers still pass KITMAKER_API_TOKEN: ${{ secrets.KITMAKER_API_TOKEN }} at the caller level. The table does not explain why that pass-through is needed or whether it can shadow the environment secret inside the reusable job. I could not verify the Actions precedence rule here. The table should show that evidence, or the design should drop the caller-level pass-through. 4. Missing stopping condition (minor). The comment lists verification and validation, but no explicit stop condition for the pending native Windows rehearsal. The description says to keep the PR in draft. The table should state what result lifts the draft. 5. Stale header (minor, not in table). The header of kumo-engine-wheel.yml (lines 8-20) still lists only check-requirements and wheel-smoke as release gates. It omits platform-qualification, which now controls Windows publication. I did not find a proven code defect in the workflow or packaging changes.

Resolution

  1. Update the change map to list .github/workflows/kumo-glove-6b-50d-wheel.yml as a second caller of kitmaker-portal.yml. State that the optional KITMAKER_API_TOKEN now fails inside the kumo-engine-release environment, not at call validation. Confirm that this effect is acceptable for the glove release. 2. Correct the pyproject.toml rationale. Replace "Match intended native CPU distribution" with a statement that the classifier only declares the OS. CPU scope comes from the [cpu] extra and accelerator="cpu" guidance. 3. Explain in the Portal row why both callers still pass KITMAKER_API_TOKEN at caller level. Show that the environment secret resolves inside the reusable portal job, for example with a dry-run or a cited Actions behavior. If it does not, remove the caller-level pass-through. 4. Add a stop condition: name the exact-candidate rehearsal result that removes draft status. Also name the condition that keeps Windows out of release if that result fails. 5. Update the release-flow header comment in .github/workflows/kumo-engine-wheel.yml to include platform-qualification as a release gate.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@danielmawhirter

Copy link
Copy Markdown
Collaborator Author

Change map

File Function / scope What changed Why
.github/workflows/kumo-engine-wheel.yml Attachment/Kitmaker matrices Enable native Windows rows behind existing qualification. Publish only qualified Windows CPU wheels.
.github/workflows/kitmaker-portal.yml Caller token contract Allow the protected Portal job to resolve its environment token. Prevent a required caller secret from blocking release validation before environment approval.
packages/kumo-engine/pyproject.toml OS classifier Declare Windows metadata. Match intended native CPU distribution.
README.md Platform overview Link native Windows CPU installation and retain WSL GPU guidance. Keep the repository entry point consistent.
packages/kumo-engine/README.md Installation Explain CPU Faiss extra and explicit CPU accelerator. Give native Windows users the qualified install path.
packages/kumo-engine/platform-smoke.md Qualification scope Separate synthetic smoke from fresh-process CPU Faiss restoration and historical evidence. Describe the actual release gates and their limits.
docs/development/releasing-kumo-engine.md Release platform policy Document Windows publication, CPU support and deferred CUDA. Align release operations with supported artifacts.
test/scripts/test_engine_wheel_workflow.py Publication/secret contracts Require platform-complete attachment/publication and environment token resolution. Guard Windows routing while preserving approval and qualification gates.

Validation: 122 focused tests pass; changed Python flake8/isort, actionlint, docs and whitespace checks pass. Native Windows exact-candidate rehearsal remains pending; no release or packages published.

This branch was previously deployed

1 inactive deployment
gha-kumo-workflow-tests — b0ff2236 Deployed Nov 18, 2026 by danielmawhirter via import #2627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant