Repository navigation
Qualify native Windows CPU wheels in fresh processes - #401
danielmawhirter wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
| Check name | Status | Explanation |
|---|---|---|
| Pr Size | The PR-size check counts changed files and fails only above 40. I fetched PR #401 (head 71da0ed) and its base branch dm-snapshot-checksums-portable. The merge-base is 8ca94eb. Diffing the merge-base… |
|
| Public Resource Access | Summary: The check passes. The PR adds external references that are public, and the one inaccessible resource is not referenced by text that this PR adds. Scope: The reviewed change is commit … |
Full details: Pr Size
-
Explanation
The PR-size check counts changed files and fails only above 40. I fetched PR
#401(head 71da0ed) and its base branch dm-snapshot-checksums-portable. The merge-base is 8ca94eb. Diffing the merge-base against the PR head with rename detection shows 6 changed files: 1 added and 5 modified. The files are: - .github/workflows/kumo-engine-platform-smoke.yml - .github/workflows/kumo-engine-wheel.yml - docs/development/releasing-kumo-engine.md - packages/kumo-engine/test/desktop_reload_qualification.py - test/scripts/test_desktop_reload_qualification.py - test/scripts/test_engine_wheel_workflow.py Six files is below the threshold of 40, so no split recommendation applies. Line counts were ignored, as the check requires.
Full details: Public Resource Access
-
Explanation
Summary: The check passes. The PR adds external references that are public, and the one inaccessible resource is not referenced by text that this PR adds. Scope: The reviewed change is commit 71da0ed against its parent 8ca94eb. The provider base branch
dm-snapshot-checksums-portableis not available locally, so this uses the parent commit as the diff base. This matches the prior run. The PR author is danielmawhirter. Added external references (verified): - GitHub Actionsuses:in.github/workflows/kumo-engine-platform-smoke.yml:actions/checkout,actions/download-artifact,astral-sh/setup-uv,aws-actions/configure-aws-credentials, andactions/upload-artifact. Anonymous probes of the repository URLs returned HTTP 200. - PyPI packageboto3in--with 'boto3>=1.34,<2'. An anonymous probe of the PyPI index returned HTTP 200. ---torch-backend=cpuand the[cpu]extra. These are installer options, not literal URLs in the diff. - Repository-local pathspackages/kumo-engine/test/pr172/inputs.json,desktop_reload_qualification.py, andwheel_gpu_smoke.py. These are local. The inaccessible S3 object: The S3 objects3://kumo-unit-test/.../a20a1e14.../pr172-inputs-v1.tar.gz(us-west-2) returns HTTP 403 to an anonymous request. This run confirmed that result. The workflow downloads it through AWS OIDC role assumption. Why it does not fail this check: The check inspects only references whose reference text is added or modified by the PR. It excludes unchanged references in changed files. - The added workflow lines read the bucket and key asspec['bucket']andspec['key']frompackages/kumo-engine/test/pr172/inputs.json. -inputs.jsonis unchanged in this PR. The diff stat shows no changes underpackages/kumo-engine/test/pr172/. - A search of the added lines found nokumo-unit-test,diskgraph-profiles, ora20a1e14literal. - The bucket and key text is therefore pre-existing and unchanged.pr172/README.mddocuments the access model: the object is read with the existing CI role, and no anonymous access is provided. Prior FAIL: The prior run treated the new download step as an added reference. I read the policy's "reference text is added" condition as literal. The added step is a new consumer of a pre-existing private reference. It is not a new reference text. This is a judgment call. Maintainers should still know that this PR makes the Windows qualification job depend on a private, CI-role-only object. That dependency is a design risk. It is outside the literal scope of this check. Other added lines: The docs change indocs/development/releasing-kumo-engine.mdand the test and workflow test changes add no URLs or package sources. Prior failure refuted: The prior FAIL rested on the premise that the PR adds the private S3 reference. The added diff lines (HEAD~1..HEAD, workflow lines 39-58) read bucket and key from unchanged packages/kumo-engine/test/pr172/inputs.json and contain no bucket, key, or s3:// literal. Per the check, unchanged references in changed files are excluded. The added references (GitHub actions repos and PyPI boto3) return H...
Full details: Change Map Design Review
-
Explanation
The check reviews the PR conversation comment that starts with
<!-- kumo-pr-change-map -->. That comment is not in the supplied PR context. The PR description only links to it (issuecomment-6993275539). No review thread was returned, and no tool in this run reads PR conversation comments. A repository search found the marker only indocs/development/review.md, which describes the convention and does not contain the comment. The localpr401branch is at commit 71da0ed, and the base refdm-snapshot-checksums-portableis not present locally. Without the change-map text, I cannot test its necessity, abstraction, behavior, or verification claims. I therefore cannot assess the design. I did not infer a pass from the PR description or from the file-level commit history.Resolution
Provide the text of the PR conversation comment that begins with
<!-- kumo-pr-change-map -->(the comment linked as issuecomment-6993275539 in PR#401). Also make the base branchdm-snapshot-checksums-portableavailable locally, for example by fetchingorigin/dm-snapshot-checksums-portable. With those inputs, the check can compare each Change map row against the committed diff in71da0ed0and the parent8ca94eb7. It can then judge necessity, abstraction layer, preserved behavior, verification, and stopping condition.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Change map
Validation: 27 focused tests and changed-Python flake8/isort pass; actionlint, docs and whitespace checks pass. Native Windows candidate run remains pending. |
6e0e28b to
8ca94eb
Compare
8002f3f to
71da0ed
Compare
Native Windows smoke tests mask ordinary loader initialization and only reload a local model bundle. Add automatic Python 3.11–3.14 qualification of the exact finished Windows wheel, including CPU Faiss retrieval, model/snapshot export and restoration in isolated fresh processes.
Stack: runtime #198 → this qualification PR → publication #402. Base:
dm-snapshot-checksums-portable. Native Windows publication remains disabled here; the new job is part of the existing required platform qualification gate. Native CUDA remains deferred.Port the existing reload harness for Windows paths, process cleanup and optional RSS diagnostics. Remove pytest/CI/loader overrides before worker imports. Qualify binary and static-link tasks with the checksum-pinned existing fixture and
[cpu]; run Windows Rust checksum and directory-durability tests with guards against zero-test success.Validation: 27 focused harness/workflow tests pass, including real POSIX subprocess isolation/cleanup; Python flake8 and isort, actionlint, documentation and whitespace checks pass. Root independently repeated the tests and exact Linux Rust durability check. Native Windows execution is pending the integrated candidate workflow. Hosted Windows evidence will not establish restricted-account or native CUDA support.
Change map
File-by-file rationale and verification.