Skip to content

Qualify native Windows CPU wheels in fresh processes - #401

Open
danielmawhirter wants to merge 1 commit into
dm-snapshot-checksums-portablefrom
dm-windows-native-qualification
Open

danielmawhirter wants to merge 1 commit into
dm-snapshot-checksums-portablefrom
dm-windows-native-qualification

Conversation

@danielmawhirter

@danielmawhirter danielmawhirter commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Native Windows smoke tests mask ordinary loader initialization and only reload a local model bundle. Add automatic Python 3.11–3.14 qualification of the exact finished Windows wheel, including CPU Faiss retrieval, model/snapshot export and restoration in isolated fresh processes.

Stack: runtime #198 → this qualification PR → publication #402. Base: dm-snapshot-checksums-portable. Native Windows publication remains disabled here; the new job is part of the existing required platform qualification gate. Native CUDA remains deferred.

Port the existing reload harness for Windows paths, process cleanup and optional RSS diagnostics. Remove pytest/CI/loader overrides before worker imports. Qualify binary and static-link tasks with the checksum-pinned existing fixture and [cpu]; run Windows Rust checksum and directory-durability tests with guards against zero-test success.

Validation: 27 focused harness/workflow tests pass, including real POSIX subprocess isolation/cleanup; Python flake8 and isort, actionlint, documentation and whitespace checks pass. Root independently repeated the tests and exact Linux Rust durability check. Native Windows execution is pending the integrated candidate workflow. Hosted Windows evidence will not establish restricted-account or native CUDA support.

Change map

File-by-file rationale and verification.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Pre-merge checks: Passed 2 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Change Map Design Review Inconclusive The check reviews the PR conversation comment that starts with <!-- kumo-pr-change-map -->. That comment is not in the supplied PR context. The PR description only links to it (issuecomment-69932755… Provide the text of the PR conversation comment that begins with <!-- kumo-pr-change-map --> (the comment linked as issuecomment-6993275539 in PR #401). Also make the base branch dm-snapshot-checksums-portable available locally, for exa…
Passed Passed checks: 2 passed

Check name Status Explanation
Pr Size Passed The PR-size check counts changed files and fails only above 40. I fetched PR #401 (head 71da0ed) and its base branch dm-snapshot-checksums-portable. The merge-base is 8ca94eb. Diffing the merge-base…
Public Resource Access Passed Summary: The check passes. The PR adds external references that are public, and the one inaccessible resource is not referenced by text that this PR adds. Scope: The reviewed change is commit …
Full details: Pr Size

Explanation

The PR-size check counts changed files and fails only above 40. I fetched PR #401 (head 71da0ed) and its base branch dm-snapshot-checksums-portable. The merge-base is 8ca94eb. Diffing the merge-base against the PR head with rename detection shows 6 changed files: 1 added and 5 modified. The files are: - .github/workflows/kumo-engine-platform-smoke.yml - .github/workflows/kumo-engine-wheel.yml - docs/development/releasing-kumo-engine.md - packages/kumo-engine/test/desktop_reload_qualification.py - test/scripts/test_desktop_reload_qualification.py - test/scripts/test_engine_wheel_workflow.py Six files is below the threshold of 40, so no split recommendation applies. Line counts were ignored, as the check requires.

Full details: Public Resource Access

Explanation

Summary: The check passes. The PR adds external references that are public, and the one inaccessible resource is not referenced by text that this PR adds. Scope: The reviewed change is commit 71da0ed against its parent 8ca94eb. The provider base branch dm-snapshot-checksums-portable is not available locally, so this uses the parent commit as the diff base. This matches the prior run. The PR author is danielmawhirter. Added external references (verified): - GitHub Actions uses: in .github/workflows/kumo-engine-platform-smoke.yml: actions/checkout, actions/download-artifact, astral-sh/setup-uv, aws-actions/configure-aws-credentials, and actions/upload-artifact. Anonymous probes of the repository URLs returned HTTP 200. - PyPI package boto3 in --with 'boto3&gt;=1.34,&lt;2'. An anonymous probe of the PyPI index returned HTTP 200. - --torch-backend=cpu and the [cpu] extra. These are installer options, not literal URLs in the diff. - Repository-local paths packages/kumo-engine/test/pr172/inputs.json, desktop_reload_qualification.py, and wheel_gpu_smoke.py. These are local. The inaccessible S3 object: The S3 object s3://kumo-unit-test/.../a20a1e14.../pr172-inputs-v1.tar.gz (us-west-2) returns HTTP 403 to an anonymous request. This run confirmed that result. The workflow downloads it through AWS OIDC role assumption. Why it does not fail this check: The check inspects only references whose reference text is added or modified by the PR. It excludes unchanged references in changed files. - The added workflow lines read the bucket and key as spec['bucket'] and spec['key'] from packages/kumo-engine/test/pr172/inputs.json. - inputs.json is unchanged in this PR. The diff stat shows no changes under packages/kumo-engine/test/pr172/. - A search of the added lines found no kumo-unit-test, diskgraph-profiles, or a20a1e14 literal. - The bucket and key text is therefore pre-existing and unchanged. pr172/README.md documents the access model: the object is read with the existing CI role, and no anonymous access is provided. Prior FAIL: The prior run treated the new download step as an added reference. I read the policy's "reference text is added" condition as literal. The added step is a new consumer of a pre-existing private reference. It is not a new reference text. This is a judgment call. Maintainers should still know that this PR makes the Windows qualification job depend on a private, CI-role-only object. That dependency is a design risk. It is outside the literal scope of this check. Other added lines: The docs change in docs/development/releasing-kumo-engine.md and the test and workflow test changes add no URLs or package sources. Prior failure refuted: The prior FAIL rested on the premise that the PR adds the private S3 reference. The added diff lines (HEAD~1..HEAD, workflow lines 39-58) read bucket and key from unchanged packages/kumo-engine/test/pr172/inputs.json and contain no bucket, key, or s3:// literal. Per the check, unchanged references in changed files are excluded. The added references (GitHub actions repos and PyPI boto3) return H...

Full details: Change Map Design Review

Explanation

The check reviews the PR conversation comment that starts with &lt;!-- kumo-pr-change-map --&gt;. That comment is not in the supplied PR context. The PR description only links to it (issuecomment-6993275539). No review thread was returned, and no tool in this run reads PR conversation comments. A repository search found the marker only in docs/development/review.md, which describes the convention and does not contain the comment. The local pr401 branch is at commit 71da0ed, and the base ref dm-snapshot-checksums-portable is not present locally. Without the change-map text, I cannot test its necessity, abstraction, behavior, or verification claims. I therefore cannot assess the design. I did not infer a pass from the PR description or from the file-level commit history.

Resolution

Provide the text of the PR conversation comment that begins with &lt;!-- kumo-pr-change-map --&gt; (the comment linked as issuecomment-6993275539 in PR #401). Also make the base branch dm-snapshot-checksums-portable available locally, for example by fetching origin/dm-snapshot-checksums-portable. With those inputs, the check can compare each Change map row against the committed diff in 71da0ed0 and the parent 8ca94eb7. It can then judge necessity, abstraction layer, preserved behavior, verification, and stopping condition.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@danielmawhirter

Copy link
Copy Markdown
Collaborator Author

Change map

File Function / scope What changed Why
.github/workflows/kumo-engine-platform-smoke.yml Windows reload job Qualify same-run Windows wheels with CPU Faiss on Python 3.11–3.14. Require fresh-process binary/retrieval restoration before release.
.github/workflows/kumo-engine-wheel.yml Windows native tests, qualification permissions Run checksum/durability cases with nonzero-test guards and grant fixture-read OIDC permission. Prevent untested native paths from passing the release gate.
packages/kumo-engine/test/desktop_reload_qualification.py Worker environment, subprocess lifecycle, platform diagnostics Port Windows temporary storage and cleanup; remove CI loader bypasses. Exercise installed-wheel user behavior and preserve fresh-process evidence.
test/scripts/test_desktop_reload_qualification.py Harness regressions Test environment isolation, Windows cleanup/races and a real subprocess lifecycle. Verify portable process behavior and storage removal.
test/scripts/test_engine_wheel_workflow.py Workflow contracts Assert exact artifact, CPU Faiss install and required native checks. Guard release-gate wiring.
docs/development/releasing-kumo-engine.md Native qualification Describe automatic native CPU restoration qualification. Keep operators informed while publication remains disabled.

Validation: 27 focused tests and changed-Python flake8/isort pass; actionlint, docs and whitespace checks pass. Native Windows candidate run remains pending.

This branch was previously deployed

1 inactive deployment
gha-kumo-workflow-tests — 71da0ed0 Deployed Nov 18, 2026 by danielmawhirter via import #2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant