Skip to content

fix: is_optional input description inverts actual behavior #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewwhitecdw wants to merge 1 commit into from
Closed

fix: is_optional input description inverts actual behavior #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/test-template/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ inputs:
description: "Test script to execute"
required: true
is_optional:
description: "Failure will cancel all other tests if set to true"
description: "Failure is ignored and other tests continue if set to true"
required: false
default: "false"
is_unit_test:
Expand Down
21 changes: 21 additions & 0 deletions unit_tests/github_actions/test_optional_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/usr/bin/env python3
"""Regression test: is_optional description matches behavior."""

import sys


def main():
with open(".github/actions/test-template/action.yml") as f:
content = f.read()

if "Failure will cancel all other tests if set to true" in content:
print("BUG: is_optional description inverts the actual behavior")
sys.exit(1)

if "is_optional:" not in content or "description:" not in content:
print("Could not find is_optional input description")
sys.exit(1)

print("OK")


Loading