Skip to content

fix: is_optional input description inverts actual behavior - #728

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:bugfix/action-is-optional-input-description-inverts
Open

fix: is_optional input description inverts actual behavior#728
andrewwhitecdw wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
andrewwhitecdw:bugfix/action-is-optional-input-description-inverts

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR fixes a script issue in .github/actions/test-template/action.yml: is_optional input description inverts actual behavior.

Changes

  • .github/actions/test-template/action.yml: is_optional input description inverts actual behavior.

Details

--- a/.github/actions/test-template/action.yml
+++ b/.github/actions/test-template/action.yml
@@ -1,1 +1,1 @@
-    description: "Failure will cancel all other tests if set to true"
+    description: "Failure is ignored and other tests continue if set to true"

Tests

  • tests/unit_tests/github_actions/test_optional_description.py
--- /dev/null
+++ tests/unit_tests/github_actions/test_optional_description.py
@@ -0,0 +1,21 @@
+#!/usr/bin/env python3
+"""Regression test: is_optional description matches behavior."""
+
+import sys
+
+
+def main():
+    with open(".github/actions/test-template/action.yml") as f:
+        content = f.read()
+
+    if "Failure will cancel all other tests if set to true" in content:
+        print("BUG: is_optional description inverts the actual behavior")
+        sys.exit(1)
+
+    if "is_optional:" not in content or "description:" not in content:
+        print("Could not find is_optional input description")
+        sys.exit(1)
+
+    print("OK")
+
+
+if __name__ == "__main__":
+    main()

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: Andrew White <andrewh@cdw.com>
@andrewwhitecdw
andrewwhitecdw requested a review from a team as a code owner July 31, 2026 17:21
@copy-pr-bot

copy-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI label Jul 31, 2026
@andrewwhitecdw
andrewwhitecdw deleted the bugfix/action-is-optional-input-description-inverts branch August 2, 2026 14:03
@andrewwhitecdw
andrewwhitecdw restored the bugfix/action-is-optional-input-description-inverts branch August 17, 2026 20:30
@andrewwhitecdw

Copy link
Copy Markdown
Contributor Author

script closed on accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant