Box-station patch 1

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Last match in file takes precedence.
-
+* @HardLightSector/review-team
 # Sorting by path instead of by who added it one day :(
 # this isn't how codeowners rules work pls read the first comment instead of trying to force a sorting order
 

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -16,7 +16,7 @@ body:
     attributes:
       label: What happened?
       description: Describe what actually occurred, including any error messages.
-      placeholder: "When I do X, Y occurs. Error log: ..."
+      placeholder: "When I do X, Y occurs. Error logs or images also help!"
     validations:
       required: true
 
@@ -51,37 +51,9 @@ body:
         - Minor (visual glitch, typo, annoyance)
         - Moderate (feature partially broken, workaround exists)
         - Major (feature completely broken, impacts gameplay)
-        - Critical (crash, data loss, server issue)
     validations:
       required: true
 
-  - type: input
-    id: version
-    attributes:
-      label: Game version / build
-      description: Which version of Hardlight are you running?
-      placeholder: "e.g., v1.2.3 or latest main branch commit hash"
-    validations:
-      required: true
-
-  - type: input
-    id: context
-    attributes:
-      label: Server / Round ID / Timestamp
-      description: If applicable – helps us match server logs.
-      placeholder: "e.g., Hardlight-Main, Round 4821, 2026-05-06 ~14:30 UTC"
-    validations:
-      required: false
-
-  - type: textarea
-    id: logs
-    attributes:
-      label: Relevant logs / screenshots
-      description: Paste any error logs, console output, or attach screenshots.
-      placeholder: "Paste logs here or drag and drop images"
-    validations:
-      required: false
-
   - type: checkboxes
     id: checklist
     attributes:
@@ -92,5 +64,3 @@ body:
           required: true
         - label: I can reproduce this bug consistently with the steps above
           required: true
-        - label: I understand that bug fixes will be tested locally before PR and tested again before merge
-          required: true

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,11 +1,10 @@
-
-
 ## About the PR
 <!-- What did you change? -->
 <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. -->
 
 ## Why / Balance
 <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. -->
+<!-- If your PR closes an open issue put `closes #issuenumber` here so that the accompanying issue is automatically closed-->
 
 ## Technical details
 <!-- Summary of code changes for easier review. -->
@@ -14,7 +13,7 @@
 <!-- Describe a procedure to test this feature, along with expected output/behavior. -->
 
 ## Media
-<!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). 
+<!-- Attach media if the PR makes ingame changes (clothing, items, features, etc).
 Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. -->
 
 ## Breaking changes

.github/actions/apply-label/action.yml

@@ -0,0 +1,45 @@
+name: 'Apply Label From Artifact'
+description: 'Applies the label based on an artifact, so we can label things from weird places'
+
+outputs:
+  pr_num:
+    description: "The PR Number"
+    value: ${{ steps.pr_data.outputs.pr_num }}
+
+runs:
+  using: "composite"
+  steps:
+    - name: Fetch Run Artifact
+      uses: actions/download-artifact@v4
+      with:
+        merge-multiple: true
+        github-token: ${{ github.token }}
+        run-id: ${{ github.event.workflow_run.id }}
+
+    - name: Parse and Apply Label
+      id: pr_data
+      shell: bash
+      env:
+        GH_TOKEN: ${{ github.token }}
+      run: |
+        if [ ! -f "NR" ]; then
+          echo "Missing Data"
+          exit 0
+        fi
+        PR_NUMBER=$(cat NR)
+        LABEL_NAME=$(cat LABEL)
+
+        gh pr edit "$PR_NUMBER" --repo "${{ github.repository }}" --add-label "$LABEL_NAME"
+        echo "pr_num=$PR_NUMBER" >> $GITHUB_OUTPUT
+
+    # Delete cuz disk space is expensive in this economy
+    - name: Delete Artifact
+      shell: bash
+      env:
+        GH_TOKEN: ${{ github.token }}
+        TARGET_NAME: pr-approval-${{ github.event.workflow_run.id }}
+      run: |
+        ID=$(gh api repos/${{ github.repository }}/actions/artifacts --jq ".artifacts[] | select(.name==\"$TARGET_NAME\") | .id" | head -n 1)
+        if [ ! -z "$ID" ]; then
+          gh api --method DELETE repos/${{ github.repository }}/actions/artifacts/$ID
+        fi

.github/labeler.yml

@@ -42,10 +42,6 @@
 - changed-files:
   - any-glob-to-any-file: "**/*.xaml*"
 
-"C#":
-- changed-files:
-  - any-glob-to-any-file: "**/*.cs"
-
 "Shaders":
 - changed-files:
   - any-glob-to-any-file: '**/*.swsl'

.github/workflows/build-test-debug.yml

@@ -1,29 +1,30 @@
 name: Build & Test Debug
 
 on:
-  push:
-    branches: [ master, staging, stable ]
   merge_group:
   pull_request:
     types: [ opened, reopened, synchronize, ready_for_review ]
     branches: [ master, staging, stable ]
 
+concurrency:
+  group: integration-tests-${{ github.event.pull_request.number }}
+  cancel-in-progress: true
+
 jobs:
   build:
     if: github.actor != 'PJBot' && github.event.pull_request.draft == false && github.actor != 'FrontierATC' # Frontier
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+    name: Build Client & Server
+    outputs:
+      test-list: ${{ steps.listtests.outputs.tests }}
 
     steps:
+      # Make sure we check out the exact SHA that started the flow, so we don't test someone elses code
     - name: Checkout Master
-      uses: actions/checkout@v4.2.2
-
-    - name: Setup Submodule
-      run: |
-        git submodule update --init --recursive
+      uses: actions/checkout@v7
+      with:
+        ref: ${{ github.event.pull_request.head.sha || github.sha }}
+        submodules: recursive
 
     - name: Pull engine updates
       uses: space-wizards/submodule-dependency@v0.1.5
@@ -34,28 +35,156 @@ jobs:
         git submodule update --init --recursive
 
     - name: Setup .NET Core
-      uses: actions/setup-dotnet@v4.1.0
+      uses: actions/setup-dotnet@v5
       with:
-        dotnet-version: 9.0.x
+        dotnet-version: 10.0.100
 
     - name: Install dependencies
       run: dotnet restore
 
     - name: Build Project
       run: dotnet build --configuration DebugOpt --no-restore /p:WarningsAsErrors=nullable /m
 
-    - name: Run Content.Tests
-      run: dotnet test --no-build --configuration DebugOpt Content.Tests/Content.Tests.csproj -- NUnit.ConsoleOut=0
+    # This takes all the test namespaces and puts them into the output so we can run multiple jobs for the tests at once
+    - name: List all Tests
+      id: listtests
+      run: |
+        echo "tests=$(dotnet test  --no-build Content.IntegrationTests/Content.IntegrationTests.csproj \
+        --list-tests -- NUnit.DisplayName=FullName \
+        | grep -E "^[[:space:]]+[A-Za-z0-9_]+\." \
+        | sed 's/^[[:space:]]*//' \
+        | awk -F. '{print $1"."$2"."$3"."$4}' \
+        | sort -u | jq -R . | jq -s -c .)" >> "$GITHUB_OUTPUT"
+
+    # Rather than re-building for every test, we store the built workspace and just share that between all the jobs
+    - name: Cache Build Objects
+      uses: actions/cache/save@v5
+      with:
+        path: bin
+        key: build-pr-${{ github.event.pull_request.number }}
+
+  # We have to checkout because the tests look for a bunch of local resources
+  # But the cache means we don't have to re-build every time at least.
+  tests:
+    runs-on: ubuntu-latest
+    name: Run Tests
+    needs: build
+    steps:
+    - name: Checkout Master
+      uses: actions/checkout@v7
+      with:
+        ref: ${{ github.event.pull_request.head.sha || github.sha }}
+        submodules: recursive
+
+    - name: Setup .NET Core
+      uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: 10.0.100
+
+    - name: Fetch Pre-Built Workspace
+      id: fetch
+      continue-on-error: true
+      uses: actions/cache/restore@v5
+      with:
+        path: bin
+        key: build-pr-${{ github.event.pull_request.number }}
+        fail-on-cache-miss: true
+
+    - name: Re-Build the files if the cached build is missing
+      if: steps.fetch.outcome == 'failure'
+      run: |
+        dotnet restore
+        dotnet build --configuration DebugOpt --no-restore /p:WarningsAsErrors=nullable /m
+
+    - name: Run Tests
+      run: dotnet vstest ./bin/Content.Tests/Content.Tests.dll -- NUnit.ConsoleOut=0
+
+
+  integrationtests:
+    runs-on: ubuntu-latest
+    needs: build
+    name: Run Integration Tests
+    strategy:
+      fail-fast: false
+      max-parallel: 20
+      matrix:
+        test: ${{ fromJson(needs.build.outputs.test-list) }}
+    steps:
+    - name: Checkout Master
+      uses: actions/checkout@v7
+      with:
+        ref: ${{ github.event.pull_request.head.sha || github.sha }}
+        submodules: recursive
+
+    # Github sometimes gets a bit angry if ALL the jobs hit the cache at once, so staggering a little bit seems to make them start happier
+    - name: Delay to stagger starts
+      run: |
+        DELAY=$((1 + RANDOM % 15))
+        echo "Staggering for $DELAY seconds"
+        sleep $DELAY
 
-    - name: Run Content.IntegrationTests
-      shell: pwsh
+    - name: Setup .NET Core
+      uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: 10.0.100
+
+    - name: Fetch Pre-Built Workspace
+      id: fetch
+      continue-on-error: true
+      uses: actions/cache/restore@v5
+      with:
+        path: bin
+        key: build-pr-${{ github.event.pull_request.number }}
+        fail-on-cache-miss: true
+
+    - name: Re-Build the files if the cached build is missing
+      if: steps.fetch.outcome == 'failure'
+      run: |
+        dotnet restore
+        dotnet build --configuration DebugOpt --no-restore /p:WarningsAsErrors=nullable /m
+
+    - name: Run Integration Tests
+      continue-on-error: true
+      id: integrationtestrun
+      env:
+        DOTNET_GCHighMemPercent: 75
+      run: |
+        dotnet test ./bin/Content.IntegrationTests/Content.IntegrationTests.dll \
+        --logger "console;verbosity=normal" \
+        --filter "FullyQualifiedName~${{ matrix.test }}" -- \
+        NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed
+
+    # For some reason, the github runners just randomly crash
+    # If they do, re-run the tests and slow things down a bit
+    # But also upload the crash dump as an artifact in-case things are really broken.
+    - name: Re-Run Integration Tests on failure
+      if: steps.integrationtestrun.outcome == 'failure'
+      env:
+        DOTNET_gcServer: 0
+        DOTNET_GCHighMemPercent: 75
+        ROBUST_TEST_THREADS: 2
       run: |
-        $env:DOTNET_gcServer=1
-        dotnet test --no-build --configuration DebugOpt Content.IntegrationTests/Content.IntegrationTests.csproj --filter "FullyQualifiedName!~ShipyardTest" -- NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed
+        dotnet test ./bin/Content.IntegrationTests/Content.IntegrationTests.dll \
+        --logger "console;verbosity=normal" \
+        --blame-crash --blame-crash-dump-type mini \
+        --filter "FullyQualifiedName~${{ matrix.test }}" -- \
+        MaxCpuCount=1 NUnit.NumberOfTestWorkers=1 NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed
+
+    - name: Upload Crash Dump
+      if: failure() && steps.integrationtestrun.outcome == 'failure'
+      uses: actions/upload-artifact@v4
+      with:
+        name: crash-dump-${{matrix.test}}
+        retention-days: 3
+        path: |
+          **/TestResults/**/*.xml
+          **/TestResults/**/*.dmp
+
   ci-success:
-    name: Build & Test Debug
+    name: Testing Success
     needs:
-      - build
+      - tests
+      - integrationtests
     runs-on: ubuntu-latest
     steps:
       - name: CI succeeded

.github/workflows/changelog.yml

@@ -1,5 +1,9 @@
 name: PR Changelogs
-concurrency: commit_action
+concurrency:
+  group: commit_action
+  cancel-in-progress: false
+  queue: max
+
 on:
   pull_request_target:
     types: [closed]
@@ -40,6 +44,7 @@ jobs:
         shell: bash
 
       - name: Generate Changelog
+        id: gen_changelog
         run: |
           cd "Tools/changelog"
           node changelog.js
@@ -53,3 +58,10 @@ jobs:
           git push
         shell: bash
         continue-on-error: true
+
+      - name: Publish changelog
+        run: Tools/actions_changelog_publish_discord.py
+        env:
+          DISCORD_WEBHOOK_URL: ${{ secrets.CHANGELOG_DISCORD_WEBHOOK }}
+          DISCORD_CHANGELOG: ${{ steps.gen_changelog.outputs.changelog }}
+        continue-on-error: true