Box-station patch 1 - #1
Closed
Mspaintwizard wants to merge 298 commits into
Closed
Conversation
* Amber arrivals changes. Initial commit. * Minor decoration changes. * Gateway re-attaching. * Maps and radars for Amber arms. * Amber quick fix (Medical/arrivals) --------- Co-authored-by: FieryTech <me@welcome.com>
* Add bwoink panel playerlist margin * Reorder ui and colour text on checkbox
* Bionic Spinarette Fix * Bionic Spinarette Fix * Bionic Spinarette Fix * Bionic Spinarette Fix and Trait Merge * Bionic Spinarette Trait Merge, Debug Fix * Fix: Set FailureLevel to Fatal to prevent ERROR logs from failing integration tests * Fix: Set FailureLevel to Fatal to prevent ERROR logs from failing integration tests * Bionic Spinarette Duplicate Hotfi * Fix: Only fail tests on ERROR logs that have actual exceptions The PoolTestLogHandler was failing tests on all ERROR-level logs, even those without associated exceptions. This was causing numerous false test failures in integration tests. Root cause: The Log() method was calling Assert.Fail() for every ERROR-level log regardless of whether an exception was present. Solution: Added a null check on message.Exception so the test only fails when there's an actual exception to report, allowing informational ERROR logs to be recorded without failing the test. This fixes excessive integration test failures (73 tests) from errors like: - Entity deserialization failures (invalid EntityUid references) - Appearance system resolution issues - Paint visualizer errors during state application * Timeout Increase * Revert "Timeout Increase" This reverts commit c706554. * Apply Tag suggestion from @re-silvered Thanks you! Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com> * Apply Tags Suggestions from re-silvered Will try to seperately PR the rest of files Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com> * Deleted tatus * Merged a file into _HL * Remove amber.yml changes from this branch * Remove PoolTestLogHandler from this PR --------- Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com>
* Updated AI remote and positronic brain system with regards to AI control. AI now required a borg to have a special brain inserted which refuses ghost roles and allows for long range AI shunting. Added new AIShuntReceiver brain and graphic for borgs. * Updated the copyright for the meta used for the ai shunt receiver to give proper credit to the PAI face designer.
…it. (HardLightSector#2030) * misc fixes * Update Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com> * Update Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com> --------- Co-authored-by: Vonte <Jontpett@yahoo.se> Co-authored-by: re-silvered <254359714+re-silvered@users.noreply.github.com>
* fix widow not being able to be sealed * add 2x2 frame to recipes * add missing moth food recipes Update moth.yml * i am a fool * linter appeasement efforts
* Multi-Track Drifting! Open Valve on dispensers now pulls from stored bottles and containers instead of the beaker slot. * Filter It Out Plumbing Filters work now.
* rambler texture * whoops forgot the meta file
…dLightSector#2040) * Add method for item deletion during midshift cleanup Update GameTicker.RoundFlow.cs * more cleanup, + commenting * nukedisk removed as precaution
* Attempts to fix synths * better fix
* Attempting to get prizeball trait working * Fixed a few minor issues Updated Prizeball laying systems to match the equivalent LewdEggLaying System, and made the trait appear in the traits tab * Fixed some langaunge in the en localization * Fixed some minor things Removed the HL tag from comments on code in HL folder Fixed the flavor Fixed maxPballs being maxEggs in lewd.yml * Actually fixed the Linter issue this time, I hope
* Update core.yml * Update core.yml
* Updated underpriced shuttles to cost more than sale price. * Undid bugfixes on two shuttles * Updating Nest and Bullet to line up with expected price
… permission issues. I hate it and I want to go home. (HardLightSector#2204)
… borgs t…" (HardLightSector#2212) This reverts commit bf725e0.
…ightSector#1870) (HardLightSector#2198) * fix regeneration traits not working * passive damage stacking * attributes --------- Co-authored-by: DeNatus <211457422+NatusExVacuo@users.noreply.github.com>
* Added contribution guidelines * changed community liason impact on the definition of done * loosened PR guidelines * removed GitHub issue creation as requirement * Removed the Definition of Done in favor for a dedicated QA team deciding when a feature is deemed ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This patch is a much needed patch to box station, focusing mainly on making the station feel less out of date design wise compared to some other stations, this main patch focuses on the arrivals area and the maintenance areas. both of thees areas will be updated in the future after the community views upon the areas and gives me some inspiration.
Why / Balance
Box station was one of the oldest stations we have that had not received a patch outside of quick careless additions, i wanted to change that because the station is quite nice on a conceptual level with its design.
Also have you ever seen anyone in maints on this station? I literally never have. Not while ghosting or in play. A part of this patch makes the maints interesting to interact with so that hopefully does not stay that way.
I should reiterate, box station was so untouched and un-cared for that the security was a majority redsec in design.
Technical details
N/a
How to test
Loadmap 300 maps/box.yml
Ghost
Media
Breaking changes
N/A
Changelog