Repository navigation
Classify model provider rejections - #694
Merged
Merged
Conversation
SaladDay
force-pushed
the
classify-model-provider-rejections
branch
2 times, most recently
from
October 14, 2026 07:01
39d4815 to
2c85b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
codexErrorInfo: "other"and puts the provider's response body in the Turn error message. When that message is a JSON object with an objecterrormember, the adapter reports that member's owncodeortypeif it is an accepted code (for example an OpenAI-compatiblecontext_length_exceeded), otherwiseinvalid_request, on the existing Core–Runtime error frame. Any otherothermessage stays unclassified, including a plain-text 400 body and Codex'sunexpected statustext for provider 401 and 404 responses.errornotification stream and again inturn/completed, and the adapter used to append both. It now appends the buffered notification text only when it differs from the Turn error.-32603with prose only.No wire, Core or declared-code change. Core already maps
engine_failed+invalid_requestto theinvalid_requestdiagnostic (TestDiagnosticNativeClassification), andinvalid_requestalready counts as a model provider observation.Why
On mx, the failed Sessions
b2f8e093…andf7f09b34…ran Codex against the MiniMax API (https://api.minimaxi.com/v1, Responses) with an unknown model name. MiniMax answered HTTP 400{"error":{"message":"invalid params, code: 2013, msg: invalid params, unknown model '<model>' (2013)","code":"invalid_prompt"}}. Codex reportedother, so the Turn had noengine_error_code, diagnostics showedharness_errorand Web said only that the Harness did not report a reason. The stored error repeated the provider message twice.Verification
go test ./apps/daemon/internal/agent/codex/ -count=1: pass. The lean test covers a 400 JSON body without a declared code (invalid_request), one withcode: context_length_exceeded, one withtype: authentication_error, prose and a non-objecterror, and the single stored message; it reads envelopes with a bounded receive.go test ./services/core/internal/api -run TestDiagnostic -count=1: pass.make check-runtime-contract: pass.go vet ./...: pass.make check-names check-docsand the website translation guard (pnpm check-translations): pass.othervariant and messages above. These probes were not committed.code="invalid_request"and textinvalid_prompt: invalid params, code: 2013, msg: invalid params, unknown model 'lane-b-unknown-model' (2013), shown once. This probe was not committed.Skipped
make check: skipped under the focused-checks rule.