Repository navigation
Make failed Sessions actionable - #699
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
make-failed-sessions-actionable
branch
from
October 14, 2026 06:59
6202f70 to
2c3e78d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
invalid_requestreads "The model provider rejected the request. Check the model and parameters, starting with the model on the Session page." It does not claim the model ID is wrong, because Codex also reports some of its own errors asbadRequest.authentication_error,connection_failed,invalid_request,resource_not_foundandharness_erroradd where the model provider comes from: "Without a model provider set on the Session or its saved Agent, a hosted sandbox Session uses the default in Settings → Models and credentials". A self-hosted Session never uses that default.runtime_unavailableandruntime_disconnectedread "Retry later. For a self-hosted Session, check Host connection on the Session page; for a hosted sandbox Session, check Settings → Sandbox and scheduling". This holds for E2B too, which has no nodes.cyber_policygets a next step, andmodel_provider_requirednames the Session, its saved Agent and the hosted default.harness_erroris kept for unclassified failures only, and its copy says Core does not show the Harness's own message.lib/session-title.tsholds the single fallback rule: metadatatitle, then the Agent's name, then "Untitled Session" / "未命名 Session". It is used on Overview, the Session log, the Session page and Sandbox metrics. This replaces three local copies and two per-page "untitled" strings.apps/web/PRODUCT.md,docs/web/index.mdanddocs/web/console-api-usage.md(EN+zh,source_hashrefreshed) describe the 24-hour bound, the partial qualification, the reason plus next step, and the naming rule.No new route, field, setting or stored state. The only new names are locale keys:
diagnostics.next.*,diagnostics.sentenceGap(en " ", zh ""),common.untitledSessionandoverview.attention.emptyOlder*.Why
On mx, an operator who opened a failed Session saw "the Harness did not report a reason" with no next step, even for a plain unknown-model rejection. The attention list mixed in failures from days ago. Untitled Sessions also got different fallback names on different pages.
#694 makes Codex report that rejection as
invalid_request. This PR makes Web say what that means and what to check. The two PRs are independent.The Harness or provider message stays out of Web. The session-diagnostics contract keeps native text out of diagnostics, and the public Session error is fixed text. Instead, the
harness_errorcopy says that Core does not show the message.Verification
pnpm --filter @oac/web typecheck: pass.vitest runon the sessions, overview, metrics, i18n, lib and provider-observations tests: 31 files and 191 tests pass. The diagnostics test checks exact en and zh text forinvalid_request, and theruntime_unavailableandconnection_failed502 steps. It also checksharness_error, and that truncated rows keep the next step in the tooltip. The Overview tests cover attention filtering by the window.e2e/diagnostics.spec.ts,e2e/overview-readiness.spec.tsande2e/provider-observations.spec.ts, against the fixture with bundled Chromium: 14 passed. The partial-refresh test now also checks the Partial chip on the Needs attention tile and section.pnpm test(22 tests, including the translation,source_hashand link guards): pass.make check-names check-docs: pass.internal_error.Skipped
make check: skipped under the focused-checks rule.