Skip to content

ci(publish-preview): pass typed inputs to the reusable workflow - #174

Merged
Mrtenz merged 1 commit into
mainfrom
mrtenz/fix-publish-preview-input-types
Nov 13, 2026
Merged

Mrtenz merged 1 commit into
mainfrom
mrtenz/fix-publish-preview-input-types

Conversation

@Mrtenz

@Mrtenz Mrtenz commented Nov 13, 2026

Copy link
Copy Markdown
Member

Explanation

The workflow_dispatch trigger added in #173 fails to start. github.event.inputs always yields strings, so the reusable workflow rejected the empty pull-request value (a number) and the dry-run value (a boolean) with Unexpected value. This switches the three with: values to the typed inputs context.

References

None.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

`github.event.inputs` always yields strings, so the reusable workflow rejected the empty `pull-request` value (a `number`) and the `dry-run` value (a `boolean`). Use the typed `inputs` context instead.
@Mrtenz
Mrtenz marked this pull request as ready for review November 13, 2026 16:43
@Mrtenz
Mrtenz requested a review from a team as a code owner November 13, 2026 16:43
@Mrtenz
Mrtenz deployed to default-branch November 13, 2026 16:43 — with GitHub Actions Active
@Mrtenz
Mrtenz enabled auto-merge November 13, 2026 16:44
@Mrtenz
Mrtenz added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit a3e2c0a Nov 13, 2026
62 checks passed
@Mrtenz
Mrtenz deleted the mrtenz/fix-publish-preview-input-types branch November 13, 2026 16:47

This branch was successfully deployed

1 active deployment
default-branch — 869e759a Deployed Nov 13, 2026 by Mrtenz via Determine whether this PR is a release PR #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants