Repository navigation
ci(publish-preview): convert the pull-request input to a number - #175
Merged
Merged
Conversation
A `workflow_dispatch` number input reaches the `inputs` context as a string, so the reusable workflow rejected both an empty value and `0` for its `number` input. Convert it with `fromJSON`, falling back to `0` when the input is blank. The reusable workflow treats `0` as unset.
cryptodev-2s
approved these changes
Nov 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The typed
inputscontext added in #174 was not enough. Aworkflow_dispatchnumber input reaches theinputscontext as a string, so the reusable workflow still rejected both an emptypull-requestvalue and0for itsnumberinput withUnexpected value. This converts the input withfromJSONand falls back to0when it is blank. The reusable workflow inMetaMask/github-toolstreats0as unset (inputs.pull-request || github.event.issue.number), so thebranchinput keeps working.References
None.
Checklist