Skip to content

CELE-148 Fix missing await for async workspace creation #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelpiano merged 3 commits into from
Aug 29, 2025
Merged

CELE-148 Fix missing await for async workspace creation #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
284562d
CELE-148 Fix missing await for async workspace creation
aranega Aug 27, 2025
e3fdac8
CELE-148 Fix dataset panel height
aranega Aug 27, 2025
2bee4bb
CELE-148 Update limites for the pod
aranega Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions applications/visualizer/deploy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ harness:
port: 8080
replicas: 1
resources:
# limits:
# cpu: '0.50'
# memory: 500M
limits:
cpu: "0.50"
memory: 2000M
requests:
cpu: "0.25"
# memory: 2000Mi
Expand Down
4 changes: 2 additions & 2 deletions applications/visualizer/frontend/src/components/CreateNewWorkspaceDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const CreateNewWorkspaceDialog = ({ onCloseCreateWorkspace, showCreateWorkspaceD
return Object.values(workspaces).some((workspace) => workspace.name === name);
};

const handleSubmit = () => {
const handleSubmit = async () => {
if (!formValues.workspaceName.trim()) {
setErrorMessage("Workspace name is required!");
return;
Expand All @@ -89,7 +89,7 @@ const CreateNewWorkspaceDialog = ({ onCloseCreateWorkspace, showCreateWorkspaceD
const newWorkspaceId = `workspace-${randomNumber}`;
const activeNeurons = new Set(formValues.selectedNeurons);
const activeDatasets = new Set(formValues.selectedDatasets.map((dataset) => dataset.id));
createWorkspace(newWorkspaceId, formValues.workspaceName, activeDatasets, activeNeurons);
await createWorkspace(newWorkspaceId, formValues.workspaceName, activeDatasets, activeNeurons);

if (isCompareMode) {
const updatedWorkspaces = new Set([...Object.keys(workspaces), newWorkspaceId]);
Expand Down
3 changes: 1 addition & 2 deletions applications/visualizer/frontend/src/components/ViewerContainer/DataSets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const DataSets = ({ children }) => {
);

return (
<Box>
<Box display="flex" flexDirection="column">
<Stack spacing=".25rem" p=".75rem" mb="1.5rem" pb="0">
<Typography variant="body1" component="p" color={gray900} fontWeight={500}>
Datasets
Expand Down Expand Up @@ -339,7 +339,6 @@ const DataSets = ({ children }) => {
</Box>
<Box
sx={{
height: "calc(100% - 12.75rem)",
paddingBottom: "0.5rem",
overflow: "auto",
}}
Expand Down
2 changes: 1 addition & 1 deletion applications/visualizer/frontend/src/contexts/GlobalContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface GlobalContextType {
viewMode: ViewMode;
selectedWorkspacesIds: Set<string>;
setViewMode: (viewMode: ViewMode) => void;
createWorkspace: (id: string, name: string, activeDatasets?: Set<string>, activeNeurons?: Set<string>) => void;
createWorkspace: (id: string, name: string, activeDatasets?: Set<string>, activeNeurons?: Set<string>) => Promise<void>;
updateWorkspace: (workspace: Workspace) => void;
removeWorkspace: (workspaceId: string) => void;
setCurrentWorkspace: (workspaceId: string) => void;
Expand Down
2 changes: 1 addition & 1 deletion applications/visualizer/frontend/src/models/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export class Workspace {
// Set EM viewer settings
if (!emViewerSettings) {
const firstActiveDataset = Object.values(activeDatasets)?.[0];
const [minSlice, maxSlice] = firstActiveDataset.emData?.sliceRange || [0, 0];
const [minSlice, maxSlice] = firstActiveDataset?.emData?.sliceRange || [0, 0];
const startSlice = Math.floor((maxSlice + minSlice) / 2);
this.emViewerSettings = {
showNeurons: true,
Expand Down